From: Fabio Estevam <festevam@gmail.com>
To: Niklas Cassel <niklas.cassel@axis.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
johan@kernel.org, Niklas Cassel <niklass@axis.com>
Subject: Re: [PATCH] net: phy: micrel: support !CONFIG_HAVE_CLK
Date: Mon, 27 Apr 2015 14:59:39 -0300 [thread overview]
Message-ID: <CAOMZO5Dg9FkGkSS7mygv3OdfdF4jOK_nbTvx8eUTGD+EMmRs0g@mail.gmail.com> (raw)
In-Reply-To: <1430132450-4496-1-git-send-email-niklass@axis.com>
On Mon, Apr 27, 2015 at 8:00 AM, Niklas Cassel <niklas.cassel@axis.com> wrote:
> Since NULL is a valid clock, we shouldn't use
> IS_ERR_OR_NULL.
Yes, but this code is not using IS_ERR_OR_NULL.
It seems that you are not describing the problem you are trying to solve.
What is the exact issue you are seeing?
> clk = devm_clk_get(&phydev->dev, "rmii-ref");
You need to provide the 'rmii-ref' in your board file or dts.
Are you doing this?
next prev parent reply other threads:[~2015-04-27 17:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 11:00 [PATCH] net: phy: micrel: support !CONFIG_HAVE_CLK Niklas Cassel
2015-04-27 11:05 ` Johan Hovold
2015-04-27 11:08 ` Johan Hovold
2015-04-27 17:40 ` David Miller
2015-04-27 17:59 ` Fabio Estevam [this message]
2015-05-04 11:30 ` Niklas Cassel
2015-05-08 14:32 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5Dg9FkGkSS7mygv3OdfdF4jOK_nbTvx8eUTGD+EMmRs0g@mail.gmail.com \
--to=festevam@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@axis.com \
--cc=niklass@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).