From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Estevam Subject: Re: [PATCH] net: phy: micrel: support !CONFIG_HAVE_CLK Date: Mon, 27 Apr 2015 14:59:39 -0300 Message-ID: References: <1430132450-4496-1-git-send-email-niklass@axis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "David S. Miller" , Florian Fainelli , "netdev@vger.kernel.org" , linux-kernel , johan@kernel.org, Niklas Cassel To: Niklas Cassel Return-path: In-Reply-To: <1430132450-4496-1-git-send-email-niklass@axis.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, Apr 27, 2015 at 8:00 AM, Niklas Cassel wrote: > Since NULL is a valid clock, we shouldn't use > IS_ERR_OR_NULL. Yes, but this code is not using IS_ERR_OR_NULL. It seems that you are not describing the problem you are trying to solve. What is the exact issue you are seeing? > clk = devm_clk_get(&phydev->dev, "rmii-ref"); You need to provide the 'rmii-ref' in your board file or dts. Are you doing this?