From: Lijun Pan <lijunp213@gmail.com>
To: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
Cc: Networking <netdev@vger.kernel.org>,
Dany Madden <drt@linux.ibm.com>,
Rick Lindsley <ricklind@linux.ibm.com>,
Brian King <brking@linux.ibm.com>,
Cristobal Forno <cforno12@linux.ibm.com>
Subject: Re: [PATCH net 7/7] ibmvnic: parenthesize a check
Date: Thu, 24 Jun 2021 00:50:57 -0500 [thread overview]
Message-ID: <CAOhMmr7vpmgQPSJ7Ga0kbCU++QsoaFnd7KetWp38mszad7=Xmw@mail.gmail.com> (raw)
In-Reply-To: <20210624041316.567622-8-sukadev@linux.ibm.com>
On Wed, Jun 23, 2021 at 11:17 PM Sukadev Bhattiprolu
<sukadev@linux.ibm.com> wrote:
>
> Parenthesize a check to be more explicit and to fix a sparse warning
> seen on some distros.
>
> Fixes: 91dc5d2553fbf ("ibmvnic: fix miscellaneous checks")
> Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
> ---
> drivers/net/ethernet/ibm/ibmvnic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
> index 363a5d5503ad..697b9714fc76 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -3367,7 +3367,7 @@ static int enable_scrq_irq(struct ibmvnic_adapter *adapter,
> /* H_EOI would fail with rc = H_FUNCTION when running
> * in XIVE mode which is expected, but not an error.
> */
> - if (rc && rc != H_FUNCTION)
> + if (rc && (rc != H_FUNCTION))
It is unnecessary and this is not an issue with the latest sparse.
Just curious what was the version on that distro?
next prev parent reply other threads:[~2021-06-24 5:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 4:13 [PATCH net 0/7] ibmvnic: Assorted bug fixes Sukadev Bhattiprolu
2021-06-24 4:13 ` [PATCH net 1/7] Revert "ibmvnic: simplify reset_long_term_buff function" Sukadev Bhattiprolu
2021-06-24 6:07 ` Lijun Pan
2021-06-24 16:07 ` Sukadev Bhattiprolu
2021-06-24 4:13 ` [PATCH net 2/7] Revert "ibmvnic: remove duplicate napi_schedule call in open function" Sukadev Bhattiprolu
2021-06-24 6:20 ` Lijun Pan
2021-06-24 6:42 ` Rick Lindsley
2021-06-24 7:07 ` Rick Lindsley
2021-06-24 7:02 ` Johaan Smith
2021-06-24 7:28 ` Rick Lindsley
2021-06-24 17:05 ` Lijun Pan
2021-06-24 18:18 ` Dany Madden
2021-06-24 23:33 ` Rick Lindsley
2021-06-24 16:53 ` Lijun Pan
2021-06-24 4:13 ` [PATCH net 3/7] ibmvnic: clean pending indirect buffs during reset Sukadev Bhattiprolu
2021-06-24 4:13 ` [PATCH net 4/7] ibmvnic: account for bufs already saved in indir_buf Sukadev Bhattiprolu
2021-06-24 4:13 ` [PATCH net 5/7] ibmvnic: set ltb->buff to NULL after freeing Sukadev Bhattiprolu
2021-06-24 4:13 ` [PATCH net 6/7] ibmvnic: free tx_pool if tso_pool alloc fails Sukadev Bhattiprolu
2021-06-24 4:13 ` [PATCH net 7/7] ibmvnic: parenthesize a check Sukadev Bhattiprolu
2021-06-24 5:50 ` Lijun Pan [this message]
2021-06-24 18:30 ` [PATCH net 0/7] ibmvnic: Assorted bug fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOhMmr7vpmgQPSJ7Ga0kbCU++QsoaFnd7KetWp38mszad7=Xmw@mail.gmail.com' \
--to=lijunp213@gmail.com \
--cc=brking@linux.ibm.com \
--cc=cforno12@linux.ibm.com \
--cc=drt@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ricklind@linux.ibm.com \
--cc=sukadev@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).