From: pravin shelar <pshelar@ovn.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Jesse Gross <jesse@kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Pravin Shelar <pshelar@nicira.com>,
"David S. Miller" <davem@davemloft.net>,
Flavio Leitner <fbl@sysclose.org>
Subject: Re: [PATCH net] openvswitch: compute needed headroom for internal vports
Date: Mon, 11 Jan 2016 16:34:25 -0800 [thread overview]
Message-ID: <CAOrHB_DL6DpyoLYZroccPR7mjUuMM-JN6p-=o6XE53Ltb_Cq0w@mail.gmail.com> (raw)
In-Reply-To: <1452501788.5027.13.camel@redhat.com>
On Mon, Jan 11, 2016 at 12:43 AM, Paolo Abeni <pabeni@redhat.com> wrote:
> On Fri, 2016-01-08 at 18:44 -0800, pravin shelar wrote:
>> On Fri, Jan 8, 2016 at 4:42 PM, Jesse Gross <jesse@kernel.org> wrote:
>> > On Fri, Jan 8, 2016 at 2:53 PM, pravin shelar <pshelar@ovn.org> wrote:
>> >> On Fri, Jan 8, 2016 at 1:50 PM, Paolo Abeni <pabeni@redhat.com> wrote:
>> >>> Currently the ovs internal vports always use a default needed_headroom.
>> >>> This leads to a skb head copy while xmitting on ovs swith via vport
>> >>> that add some kind of encapsulation (gre, geneve, etc.).
>> >>>
>> >>> This patch add book-keeping for the maximum needed_headroom used by
>> >>> the non internal vports in any dp, updating it on vport creation and
>> >>> deletion.
>> >>>
>> >>> Said value is than used as needed_headroom for internal vports,
>> >>> avoiding the above copy.
>> >>>
>> >> Why is this done only for internal devices? In most common case of
>> >> traffic the packet enters OVS from tap or other netdev type vport
>> >> device.
>> >
>> > How would you influence the allocation for non-internal devices?
>>
>> Today there is no way of influencing this. But we could add new
>> skb-headroom parameter to netdev for packets that are received on the
>> device. This new parameter could be controlled from master devices
>> like OVS, Bridge, etc. To set this value we need new ndo operation. So
>> that it can work on devices like tap where it would just set this new
>> value and in case of ovs-internal or veth device, it can also update
>> needed_headroom.
>
> My idea was to continue working along this lines.
>
> However I thought to get there incrementally, i.e. handle internal
> vports only first. Can this be ok for you?
>
If the final implementation is going to change alot, then I do not see
much value in this change going in first.
next prev parent reply other threads:[~2016-01-12 0:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 21:50 [PATCH net] openvswitch: compute needed headroom for internal vports Paolo Abeni
2016-01-08 22:53 ` pravin shelar
2016-01-09 0:42 ` Jesse Gross
2016-01-09 2:44 ` pravin shelar
2016-01-11 8:43 ` Paolo Abeni
2016-01-12 0:34 ` pravin shelar [this message]
2016-01-12 19:20 ` Jesse Gross
2016-01-12 20:44 ` pravin shelar
2016-01-13 1:08 ` Jesse Gross
2016-01-13 5:27 ` pravin shelar
2016-01-13 17:30 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOrHB_DL6DpyoLYZroccPR7mjUuMM-JN6p-=o6XE53Ltb_Cq0w@mail.gmail.com' \
--to=pshelar@ovn.org \
--cc=davem@davemloft.net \
--cc=fbl@sysclose.org \
--cc=jesse@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).