From: Wei Liu <liuw@liuw.name>
To: Andrew Jones <drjones@redhat.com>
Cc: netdev@vger.kernel.org,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Campbell <ian.campbell@citrix.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen: netback: remove redundant xenvif_put
Date: Mon, 18 Feb 2013 20:58:32 +0000 [thread overview]
Message-ID: <CAOsiSVVb1idFC3wTcZLzUrsDN7z8asFHFRsVfoHERb--y_qz4w@mail.gmail.com> (raw)
In-Reply-To: <1361219360-29176-1-git-send-email-drjones@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 1224 bytes --]
On Mon, Feb 18, 2013 at 8:29 PM, Andrew Jones <drjones@redhat.com> wrote:
> netbk_fatal_tx_err() calls xenvif_carrier_off(), which does
> a xenvif_put(). As callers of netbk_fatal_tx_err should only
> have one reference to the vif at this time, then the xenvif_put
> in netbk_fatal_tx_err is one too many.
>
>
Hmm... we had a discussion on this not long ago.
http://marc.info/?l=xen-devel&m=136084174026977&w=2
Do you actually experiencing problem?
Wei.
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> drivers/net/xen-netback/netback.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/xen-netback/netback.c
> b/drivers/net/xen-netback/netback.c
> index 2b9520c..c23b9ec 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -893,7 +893,6 @@ static void netbk_fatal_tx_err(struct xenvif *vif)
> {
> netdev_err(vif->dev, "fatal error; disabling device\n");
> xenvif_carrier_off(vif);
> - xenvif_put(vif);
> }
>
> static int netbk_count_requests(struct xenvif *vif,
> --
> 1.8.1.2
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
[-- Attachment #1.2: Type: text/html, Size: 2340 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-02-18 20:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 20:29 [PATCH] xen: netback: remove redundant xenvif_put Andrew Jones
2013-02-18 20:58 ` Wei Liu [this message]
2013-02-19 5:53 ` David Miller
2013-02-19 8:03 ` [Xen-devel] " Jan Beulich
2013-02-19 8:58 ` Andrew Jones
2013-02-19 8:58 ` Ian Campbell
2013-02-19 18:06 ` David Miller
2013-02-20 9:23 ` Ian Campbell
2013-02-19 13:47 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOsiSVVb1idFC3wTcZLzUrsDN7z8asFHFRsVfoHERb--y_qz4w@mail.gmail.com \
--to=liuw@liuw.name \
--cc=drjones@redhat.com \
--cc=ian.campbell@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).