Fwd: [PATCH 1/1] update ip-sysctl.txt documentation

Fwd: [PATCH 1/1] update ip-sysctl.txt documentation

[Ani Sinha]

+netdev


---------- Forwarded message ----------
From: Ani Sinha <ani@arista.com>
Date: Tue, Jan 6, 2015 at 12:04 PM
Subject: [PATCH 1/1] update ip-sysctl.txt documentation
To: corbet@lwn.net, davem@davemloft.net, edumazet@google.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
ani@arista.com, P@draigbrady.com


Update documentation to reflect the fact that
/proc/sys/net/ipv4/route/max_size is no longer used for
ipv4.

Signed-off-by: Ani Sinha <ani@arista.com>
---
 Documentation/networking/ip-sysctl.txt |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/networking/ip-sysctl.txt
b/Documentation/networking/ip-sysctl.txt
index 9bffdfc..c8a7e37 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -64,8 +64,10 @@ fwmark_reflect - BOOLEAN
        Default: 0

 route/max_size - INTEGER
-       Maximum number of routes allowed in the kernel.  Increase
-       this when using large numbers of interfaces and/or routes.
+        Post linux kernel 3.6, this is depricated for ipv4 as route cache is no
+        longer used. For ipv6, this is used to limit the maximum number of ipv6
+        routes allowed in the kernel.  Increase this when using large
numbers of
+        interfaces and/or routes.

 neigh/default/gc_thresh1 - INTEGER
        Minimum number of entries to keep.  Garbage collector will not
--
1.7.4.4

Re: [PATCH 1/1] update ip-sysctl.txt documentation

[David Miller]

From: Ani Sinha <ani@arista.com>
Date: Tue, 6 Jan 2015 14:02:29 -0800

> +netdev

Please just make a fresh list posting, otherwise I have to spend
a lot of time editing your email to get the commit message and
other parts to come out right.

Thanks.

[PATCH 1/1] update ip-sysctl.txt documentation

[Ani Sinha]

Update documentation to reflect the fact that
/proc/sys/net/ipv4/route/max_size is no longer used for
ipv4.

Signed-off-by: Ani Sinha <ani@arista.com>
---
 Documentation/networking/ip-sysctl.txt |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index 9bffdfc..c8a7e37 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -64,8 +64,10 @@ fwmark_reflect - BOOLEAN
 	Default: 0
 
 route/max_size - INTEGER
-	Maximum number of routes allowed in the kernel.  Increase
-	this when using large numbers of interfaces and/or routes.
+        Post linux kernel 3.6, this is depricated for ipv4 as route cache is no
+        longer used. For ipv6, this is used to limit the maximum number of ipv6
+        routes allowed in the kernel.  Increase this when using large numbers of
+        interfaces and/or routes.
 
 neigh/default/gc_thresh1 - INTEGER
 	Minimum number of entries to keep.  Garbage collector will not
-- 
1.7.4.4

Re: [PATCH 1/1] update ip-sysctl.txt documentation

[Ani Sinha]

On Tue, Jan 6, 2015 at 2:31 PM, David Miller <davem@davemloft.net> wrote:
> From: Ani Sinha <ani@arista.com>
> Date: Tue, 6 Jan 2015 14:02:29 -0800
>
>> +netdev
>
> Please just make a fresh list posting, otherwise I have to spend
> a lot of time editing your email to get the commit message and
> other parts to come out right.
>

Sorry, I missed netdev. I resent the patch just now.

Re: [PATCH 1/1] update ip-sysctl.txt documentation

[David Miller]

From: Ani Sinha <ani@arista.com>
Date: Tue,  6 Jan 2015 14:33:45 -0800

> @@ -64,8 +64,10 @@ fwmark_reflect - BOOLEAN
>  	Default: 0
>  
>  route/max_size - INTEGER
> -	Maximum number of routes allowed in the kernel.  Increase
> -	this when using large numbers of interfaces and/or routes.
> +        Post linux kernel 3.6, this is depricated for ipv4 as route cache is no
> +        longer used. For ipv6, this is used to limit the maximum number of ipv6
> +        routes allowed in the kernel.  Increase this when using large numbers of
> +        interfaces and/or routes.

Please do not change the TABs into sequenes of space characters.

[PATCH 1/1] update ip-sysctl.txt documentation

[Ani Sinha]

Update documentation to reflect the fact that
/proc/sys/net/ipv4/route/max_size is no longer used for ipv4.

Signed-off-by: Ani Sinha <ani@arista.com>
---
 Documentation/networking/ip-sysctl.txt |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index 9bffdfc..2a28261 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -64,8 +64,10 @@ fwmark_reflect - BOOLEAN
 	Default: 0
 
 route/max_size - INTEGER
-	Maximum number of routes allowed in the kernel.  Increase
-	this when using large numbers of interfaces and/or routes.
+	Post linux kernel 3.6, this is deprecated for ipv4 as route cache is no
+	longer used. For ipv6, this is used to limit the maximum number of ipv6
+	routes allowed in the kernel.  Increase this when using large numbers of
+	interfaces and/or routes.
 
 neigh/default/gc_thresh1 - INTEGER
 	Minimum number of entries to keep.  Garbage collector will not
-- 
1.7.4.4

Re: [PATCH 1/1] update ip-sysctl.txt documentation

[Stephen Hemminger]

On Tue, 6 Jan 2015 14:02:29 -0800
Ani Sinha <ani@arista.com> wrote:

>  route/max_size - INTEGER
> -       Maximum number of routes allowed in the kernel.  Increase
> -       this when using large numbers of interfaces and/or routes.
> +        Post linux kernel 3.6, this is depricated for ipv4 as route cache is no
> +        longer used. For ipv6, this is used to limit the maximum number of ipv6
> +        routes allowed in the kernel.  Increase this when using large
> numbers of
> +        interfaces and/or routes.

1. You used mailer with line wrap which broke the patch.

2. The spelling is not correct 'depricated'

Re: [PATCH 1/1] update ip-sysctl.txt documentation

[Ani Sinha]

On Tue, Jan 6, 2015 at 3:48 PM, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> On Tue, 6 Jan 2015 14:02:29 -0800
> Ani Sinha <ani@arista.com> wrote:
>
>>  route/max_size - INTEGER
>> -       Maximum number of routes allowed in the kernel.  Increase
>> -       this when using large numbers of interfaces and/or routes.
>> +        Post linux kernel 3.6, this is depricated for ipv4 as route cache is no
>> +        longer used. For ipv6, this is used to limit the maximum number of ipv6
>> +        routes allowed in the kernel.  Increase this when using large
>> numbers of
>> +        interfaces and/or routes.
>
> 1. You used mailer with line wrap which broke the patch.

I used git send-email. Not sure what else to use.

>
> 2. The spelling is not correct 'depricated'

Fixed in the latest patch.

Re: [PATCH 1/1] update ip-sysctl.txt documentation

[Ani Sinha]

On Tue, Jan 6, 2015 at 2:40 PM, David Miller <davem@davemloft.net> wrote:
> From: Ani Sinha <ani@arista.com>
> Date: Tue,  6 Jan 2015 14:33:45 -0800
>
>> @@ -64,8 +64,10 @@ fwmark_reflect - BOOLEAN
>>       Default: 0
>>
>>  route/max_size - INTEGER
>> -     Maximum number of routes allowed in the kernel.  Increase
>> -     this when using large numbers of interfaces and/or routes.
>> +        Post linux kernel 3.6, this is depricated for ipv4 as route cache is no
>> +        longer used. For ipv6, this is used to limit the maximum number of ipv6
>> +        routes allowed in the kernel.  Increase this when using large numbers of
>> +        interfaces and/or routes.
>
> Please do not change the TABs into sequenes of space characters.

Fixed in the latest patch.

RE: [PATCH 1/1] update ip-sysctl.txt documentation

[David Laight]

From: Ani Sinha
> Update documentation to reflect the fact that
> /proc/sys/net/ipv4/route/max_size is no longer used for ipv4.
> 
> Signed-off-by: Ani Sinha <ani@arista.com>
> ---
>  Documentation/networking/ip-sysctl.txt |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
> index 9bffdfc..2a28261 100644
> --- a/Documentation/networking/ip-sysctl.txt
> +++ b/Documentation/networking/ip-sysctl.txt
> @@ -64,8 +64,10 @@ fwmark_reflect - BOOLEAN
>  	Default: 0
> 
>  route/max_size - INTEGER
> -	Maximum number of routes allowed in the kernel.  Increase
> -	this when using large numbers of interfaces and/or routes.
> +	Post linux kernel 3.6, this is deprecated for ipv4 as route cache is no
> +	longer used. For ipv6, this is used to limit the maximum number of ipv6
> +	routes allowed in the kernel.  Increase this when using large numbers of
> +	interfaces and/or routes.

Now imagine you are reading ip-sysctl.txt, the new text is all wrong.
Something like:
	Limit on the size of the ip route caches.
	Ignored for ipv4 after kernel 3.6 because the ipv4 route cache was removed.
	Increase this when using large numbers of interfaces and/or routes.
would read better.

	David

Re: [PATCH 1/1] update ip-sysctl.txt documentation

[Ani Sinha]

On Wed, Jan 7, 2015 at 2:11 AM, David Laight <David.Laight@aculab.com> wrote:
> From: Ani Sinha
>> Update documentation to reflect the fact that
>> /proc/sys/net/ipv4/route/max_size is no longer used for ipv4.
>>
>> Signed-off-by: Ani Sinha <ani@arista.com>
>> ---
>>  Documentation/networking/ip-sysctl.txt |    6 ++++--
>>  1 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
>> index 9bffdfc..2a28261 100644
>> --- a/Documentation/networking/ip-sysctl.txt
>> +++ b/Documentation/networking/ip-sysctl.txt
>> @@ -64,8 +64,10 @@ fwmark_reflect - BOOLEAN
>>       Default: 0
>>
>>  route/max_size - INTEGER
>> -     Maximum number of routes allowed in the kernel.  Increase
>> -     this when using large numbers of interfaces and/or routes.
>> +     Post linux kernel 3.6, this is deprecated for ipv4 as route cache is no
>> +     longer used. For ipv6, this is used to limit the maximum number of ipv6
>> +     routes allowed in the kernel.  Increase this when using large numbers of
>> +     interfaces and/or routes.
>
> Now imagine you are reading ip-sysctl.txt, the new text is all wrong.
> Something like:
>         Limit on the size of the ip route caches.
>         Ignored for ipv4 after kernel 3.6 because the ipv4 route cache was removed.
>         Increase this when using large numbers of interfaces and/or routes.
> would read better.

Ok please take a look at my patch v2.