From: Shannon Nelson <shannon.nelson@intel.com>
To: kan.liang@intel.com
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
bwh@kernel.org, Jesse Brandeburg <jesse.brandeburg@intel.com>,
andi@firstfloor.org, f.fainelli@gmail.com,
alexander.duyck@gmail.com,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
carolyn.wyborny@intel.com, donald.c.skidmore@intel.com,
mitch.a.williams@intel.com, ogerlitz@mellanox.com,
edumazet@google.com, jiri@mellanox.com, sfeldma@gmail.com,
gospo@cumulusnetworks.com, sasha.levin@oracle.com,
dsahern@gmail.com, tj@kernel.org, cascardo@redhat.com,
corbet@lwn.net
Subject: Re: [RFC 1/1] ethtool: support per queue coalesce options
Date: Tue, 8 Dec 2015 10:17:51 -0800 [thread overview]
Message-ID: <CAP-MU4PrJ7xrEmR5k_1qNeXFzybsJMo-SAPX-Us++YokX+zeGQ@mail.gmail.com> (raw)
In-Reply-To: <1449549861-12513-1-git-send-email-kan.liang@intel.com>
On Mon, Dec 7, 2015 at 8:44 PM, <kan.liang@intel.com> wrote:
> From: Kan Liang <kan.liang@intel.com>
>
> Intruduce new coalesce option "queue" to get/set coalesce value to
s/Intruduce/Introduce/
[...]
> diff --git a/ethtool.c b/ethtool.c
> index 92c40b8..7c644db 100644
> --- a/ethtool.c
> +++ b/ethtool.c
> @@ -1178,6 +1178,12 @@ static int dump_channels(const struct ethtool_channels *echannels)
>
> static int dump_coalesce(const struct ethtool_coalesce *ecoal)
> {
> + if (ecoal->queue < 0)
> + fprintf(stdout, "Queue: All\n");
If some queues have been given different settings, then "All" is
rather misleading, and there seems to be no way to indicate that some
queues have separate settings.
sln
prev parent reply other threads:[~2015-12-08 18:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 4:44 [RFC 1/1] ethtool: support per queue coalesce options kan.liang
2015-12-08 18:17 ` Shannon Nelson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP-MU4PrJ7xrEmR5k_1qNeXFzybsJMo-SAPX-Us++YokX+zeGQ@mail.gmail.com \
--to=shannon.nelson@intel.com \
--cc=alexander.duyck@gmail.com \
--cc=andi@firstfloor.org \
--cc=bwh@kernel.org \
--cc=carolyn.wyborny@intel.com \
--cc=cascardo@redhat.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gospo@cumulusnetworks.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jiri@mellanox.com \
--cc=kan.liang@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=sasha.levin@oracle.com \
--cc=sfeldma@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).