From: Kumar Kartikeya Dwivedi <memxor@gmail.com>
To: Daniel Xu <dxu@dxuuu.xyz>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, pablo@netfilter.org, fw@strlen.de,
toke@kernel.org, martin.lau@linux.dev,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v5 0/6] Support direct writes to nf_conn:mark
Date: Sat, 10 Sep 2022 02:27:38 +0200 [thread overview]
Message-ID: <CAP01T77JFBiO84iezH4Jh++vu=EEDf63KepK_jKFmjgjrHPgmw@mail.gmail.com> (raw)
In-Reply-To: <cover.1662568410.git.dxu@dxuuu.xyz>
On Wed, 7 Sept 2022 at 18:41, Daniel Xu <dxu@dxuuu.xyz> wrote:
>
> Support direct writes to nf_conn:mark from TC and XDP prog types. This
> is useful when applications want to store per-connection metadata. This
> is also particularly useful for applications that run both bpf and
> iptables/nftables because the latter can trivially access this metadata.
>
> One example use case would be if a bpf prog is responsible for advanced
> packet classification and iptables/nftables is later used for routing
> due to pre-existing/legacy code.
>
There are a couple of compile time warnings when conntrack is disabled,
../net/core/filter.c:8608:1: warning: symbol 'nf_conn_btf_access_lock'
was not declared. Should it be static?
../net/core/filter.c:8611:5: warning: symbol 'nfct_bsa' was not
declared. Should it be static?
Most likely because extern declaration is guarded by ifdefs. So just
moving those out of ifdef should work.
I guess you can send that as a follow up fix, or roll it in if you end
up respinning.
Otherwise, for the series:
Acked-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
next prev parent reply other threads:[~2022-09-10 0:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 16:40 [PATCH bpf-next v5 0/6] Support direct writes to nf_conn:mark Daniel Xu
2022-09-07 16:40 ` [PATCH bpf-next v5 1/6] bpf: Remove duplicate PTR_TO_BTF_ID RO check Daniel Xu
2022-09-07 16:40 ` [PATCH bpf-next v5 2/6] bpf: Add stub for btf_struct_access() Daniel Xu
2022-09-07 16:40 ` [PATCH bpf-next v5 3/6] bpf: Use 0 instead of NOT_INIT for btf_struct_access() writes Daniel Xu
2022-09-07 16:40 ` [PATCH bpf-next v5 4/6] bpf: Export btf_type_by_id() and bpf_log() Daniel Xu
2022-09-07 16:40 ` [PATCH bpf-next v5 5/6] bpf: Add support for writing to nf_conn:mark Daniel Xu
2022-09-07 16:40 ` [PATCH bpf-next v5 6/6] selftests/bpf: Add tests " Daniel Xu
2022-09-10 0:27 ` Kumar Kartikeya Dwivedi [this message]
2022-09-11 17:26 ` [PATCH bpf-next v5 0/6] Support direct writes " Daniel Xu
2022-09-11 0:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP01T77JFBiO84iezH4Jh++vu=EEDf63KepK_jKFmjgjrHPgmw@mail.gmail.com' \
--to=memxor@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dxu@dxuuu.xyz \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=toke@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).