From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 034A8C433E4 for ; Mon, 22 Mar 2021 12:21:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBBA8619AB for ; Mon, 22 Mar 2021 12:21:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230370AbhCVMVX (ORCPT ); Mon, 22 Mar 2021 08:21:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230236AbhCVMVO (ORCPT ); Mon, 22 Mar 2021 08:21:14 -0400 Received: from mail-vs1-xe31.google.com (mail-vs1-xe31.google.com [IPv6:2607:f8b0:4864:20::e31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDE8CC061756 for ; Mon, 22 Mar 2021 05:21:12 -0700 (PDT) Received: by mail-vs1-xe31.google.com with SMTP id l22so7330134vsr.13 for ; Mon, 22 Mar 2021 05:21:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XGgimpglaRwteb/Bgl+pO/u/VHpnAlSvFxg2F0n2KCo=; b=p6ePlsePjZxtZiq6dspm5RqfO23b/cRwiaAUzyGDHXFYH5sx1t4bJGWn0FOttl90Fl 9l+Pfmy1A5eZFy/TSoAvoVzQdfoD2qAan4ZvPA6wRfZWyReRLg4ebDoHO03QxuwMUSbG Xw/8chYtadgBTlSZOweb9p+3rtNCRRcjugB/lnaBMco22zR1SkNQM6lzIQNj8EexBez6 v7JH/YONvbt8dLTbvqGS0sAH1lBuk1leff10dNlL9TDI1CpIRaVwIzuXwq2+NNyRsGqx z1w0fgf4bGexsX5E3k40FkRmO1RTFVZAOD6tpBLRoVWKOKlZDiXK9Zj5nr2RvdtstoJq nujA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XGgimpglaRwteb/Bgl+pO/u/VHpnAlSvFxg2F0n2KCo=; b=LiP2X4ax6/y76wDOLtER5WCR2AQnDYZ/a/Z9GoBv5kWFvqboVvjVDv8AQ2k5wQG5xf k4uXa4TLjJKDLxUfrWExkrQ/b+bdf25vfMuG0/QELVk6Jlvv4Q9logbgcSzo8vi+FTxG 31yLbNIRjocYZ15Tq9AfB34e5qzjSd0fJThENxCTnOszg/T1JOZ0qPgmgR5RUtpH+6kP zgcJ04667eZC99ddjapgdIHonXRXBLxXMBNkWcIMUeRGO6pJIan1UuJ/NdXCZbGsu/K4 jxBiBimZFrQWGoTCmWH4txIlPYOreyPuc5cX6JpZCeDtYHcMwirYKHTN0IFMt4N+nTDs Gyeg== X-Gm-Message-State: AOAM530VgAGdrYTsgEWiCkbqCNlyzaw4q+rghsgzU6R0UFU3ae4X4D27 K7ZKDyJ1HYflw25rapqaPTOtAUIvIJWQe8XUtuWMUA== X-Google-Smtp-Source: ABdhPJxi1HPq3PGcbuB9unHpIbKlJszyykT5Ik5ywDW/5koSttdd0dNdIDei/RcqxPZPwkzSrOy7RcSt9jXbJOzDcy4= X-Received: by 2002:a67:2a85:: with SMTP id q127mr8477457vsq.19.1616415672109; Mon, 22 Mar 2021 05:21:12 -0700 (PDT) MIME-Version: 1.0 References: <20210315132501.441681-1-Jerome.Pouiller@silabs.com> <20210315132501.441681-9-Jerome.Pouiller@silabs.com> In-Reply-To: <20210315132501.441681-9-Jerome.Pouiller@silabs.com> From: Ulf Hansson Date: Mon, 22 Mar 2021 13:20:35 +0100 Message-ID: Subject: Re: [PATCH v5 08/24] wfx: add bus_sdio.c To: Jerome Pouiller Cc: linux-wireless , netdev , driverdevel , Linux Kernel Mailing List , Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , DTML , Rob Herring , linux-mmc , =?UTF-8?Q?Pali_Roh=C3=A1r?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 15 Mar 2021 at 14:25, Jerome Pouiller wrote: > > From: J=C3=A9r=C3=B4me Pouiller > > Signed-off-by: J=C3=A9r=C3=B4me Pouiller > --- > drivers/net/wireless/silabs/wfx/bus_sdio.c | 259 +++++++++++++++++++++ > 1 file changed, 259 insertions(+) > create mode 100644 drivers/net/wireless/silabs/wfx/bus_sdio.c [...] > +static const struct sdio_device_id wfx_sdio_ids[] =3D { > + { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILABS_WF200)= }, > + { }, > +}; > +MODULE_DEVICE_TABLE(sdio, wfx_sdio_ids); > + > +struct sdio_driver wfx_sdio_driver =3D { > + .name =3D "wfx-sdio", > + .id_table =3D wfx_sdio_ids, > + .probe =3D wfx_sdio_probe, > + .remove =3D wfx_sdio_remove, > + .drv =3D { > + .owner =3D THIS_MODULE, > + .of_match_table =3D wfx_sdio_of_match, It's not mandatory to support power management, like system suspend/resume. However, as this looks like this is a driver for an embedded SDIO device, you probably want this. If that is the case, please assign the dev_pm_ops here and implement the ->suspend|resume() callbacks. [...] Kind regards Uffe