netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeremy Brookman <jeremy.brookman@gmail.com>
To: John Eaglesham <linux@8192.net>
Cc: Jay Vosburgh <fubar@us.ibm.com>, netdev@vger.kernel.org
Subject: Re: [PATCH v6] bonding support for IPv6 transmit hashing
Date: Wed, 22 Aug 2012 13:06:45 +0100	[thread overview]
Message-ID: <CAPc2XZAWnTHaMiXjD-ucg4eLh89Yim439_QjqePxrFSinZhKrw@mail.gmail.com> (raw)
In-Reply-To: <503409DC.5010001@8192.net>

>>         If John signs off and somebody tests this, I'll post a formal
>> submssion with the full commit message.
>
> Since my last submission I ended up making some changes on my end to
> streamline the logic. I can fold together my patch with yours and test them
> later tonight. If everything looks good I'll post the changes back to the
> list.

Great - thanks for that Jay/John; will look forward to the latest
patch later. I'm actually looking at the 2.6.32 branch so have tested
a backport of Jay's patch (which only took a couple of very minor
modifications); a quick test on an 8-port bond with layer3+4 hashing
looked fine.  (Will hold off until the final patch before doing more
testing.)

Regards,

Jeremy

On Tue, Aug 21, 2012 at 11:21 PM, John Eaglesham <linux@8192.net> wrote:
> On 8/21/2012 12:19 PM, Jay Vosburgh wrote:
>>
>> Jeremy Brookman <jeremy.brookman@gmail.com> wrote:
>>
>>>> You should use a mix of tabs, as necessary, to get things to line up
>>>> how I told you they need to line up.
>>>
>>>
>>> Unless I'm missing something, this change doesn't seem to have made it
>>> through to the kernel tip, but we could really use this bugfix. Is it
>>> in a repository I didn't notice, or not yet through the review?  If
>>> it's not through the review, is any help needed to get it there?
>>
>>
>>         The submitter (John Eaglesham) never posted an updated version
>> that addressed the various comments, nor did his original patch
>> submission include a Signed-off-by.
>>
>>         I went ahead and updated the patch to address the comments; I've
>> only compile tested this.  Are you (Jeremy or John) able to test this to
>> confirm that it will hash ipv6 traffic as expected (I can test it, but
>> it won't be today)?
>>
>>         John, can you post a Signed-off-by for your patch (really, this
>> updated version of your patch)?
>>

  reply	other threads:[~2012-08-22 12:06 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-01  7:01 [PATCH v4 0/2] bonding support for IPv6 transmit hashing John Eaglesham
2012-07-01  7:01 ` [PATCH v4 1/2] Add support for IPv6 and bounds checking to transmit hashing functions John Eaglesham
2012-07-01  7:33   ` David Miller
2012-07-01  7:01 ` [PATCH v4 2/2] Update bonding driver documentation to include IPv6 transmit hashing algorithm John Eaglesham
2012-07-01  7:34   ` David Miller
2012-07-01  7:42     ` John Eaglesham
2012-07-01  8:07 ` [PATCH v5] bonding support for IPv6 transmit hashing John Eaglesham
2012-07-01 10:33   ` David Miller
2012-07-01 19:01     ` John Eaglesham
2012-07-01 19:13   ` [PATCH v6] " John Eaglesham
2012-07-02 23:33     ` Jay Vosburgh
2012-07-03  5:01       ` John Eaglesham
2012-07-03  5:14         ` David Miller
2012-07-03  5:38           ` John Eaglesham
2012-07-03  5:43             ` David Miller
2012-08-21 18:11               ` Jeremy Brookman
2012-08-21 19:19                 ` Jay Vosburgh
2012-08-21 22:21                   ` John Eaglesham
2012-08-22 12:06                     ` Jeremy Brookman [this message]
2012-08-23 10:42                   ` Jeremy Brookman
2012-08-22  5:12     ` [PATCH v7] bonding: " John Eaglesham
2012-08-22  5:29       ` David Miller
2012-08-22  6:43       ` [PATCH v8] " John Eaglesham
2012-08-23  5:49         ` David Miller
2012-08-23 12:23         ` Jeremy Brookman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPc2XZAWnTHaMiXjD-ucg4eLh89Yim439_QjqePxrFSinZhKrw@mail.gmail.com \
    --to=jeremy.brookman@gmail.com \
    --cc=fubar@us.ibm.com \
    --cc=linux@8192.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).