From: Wei Yongjun <weiyj.lk@gmail.com>
To: David.Laight@ACULAB.COM
Cc: divy@chelsio.com, yongjun_wei@trendmicro.com.cn, netdev@vger.kernel.org
Subject: Re: [PATCH] cxgb3: remove pointless conditional before kfree_skb()
Date: Tue, 28 Aug 2012 22:19:57 +0800 [thread overview]
Message-ID: <CAPgLHd8RKXR-TSnbJLQ2GR28ORB7HTe4kDk8wkwo_e-r+0ue4w@mail.gmail.com> (raw)
On 08/28/2012 09:24 PM, David Laight wrote:
>> - if (t->nofail_skb)
>> - kfree_skb(t->nofail_skb);
>> + kfree_skb(t->nofail_skb);
> Some of these conditionals might be there for performance
> reasons - eg if common path and normally NULL.
I have a quick look at those code, cxgb3_offload_deactivate()
is only used when remove device or device error and then disable
the device, so maybe it is not a common path.
next reply other threads:[~2012-08-28 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 14:19 Wei Yongjun [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-28 13:04 [PATCH] cxgb3: remove pointless conditional before kfree_skb() Wei Yongjun
2012-08-28 13:24 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPgLHd8RKXR-TSnbJLQ2GR28ORB7HTe4kDk8wkwo_e-r+0ue4w@mail.gmail.com \
--to=weiyj.lk@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=divy@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).