From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Mason Subject: Re: [PATCH] vxge: Declare MODULE_FIRMWARE usage Date: Thu, 26 Jul 2012 12:55:07 -0700 Message-ID: References: <1343329710-96747-1-git-send-email-tim.gardner@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Joe Perches , Jiri Pirko , Stephen Hemminger , Paul Gortmaker , netdev@vger.kernel.org To: Tim Gardner Return-path: In-Reply-To: <1343329710-96747-1-git-send-email-tim.gardner@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, Jul 26, 2012 at 12:08 PM, Tim Gardner wrote: > Cc: Jon Mason > Cc: "David S. Miller" > Cc: Joe Perches > Cc: Jiri Pirko > Cc: Stephen Hemminger > Cc: Paul Gortmaker > Cc: netdev@vger.kernel.org > Signed-off-by: Tim Gardner > --- > drivers/net/ethernet/neterion/vxge/vxge-main.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-main.c > index de21904..d4832b2 100644 > --- a/drivers/net/ethernet/neterion/vxge/vxge-main.c > +++ b/drivers/net/ethernet/neterion/vxge/vxge-main.c > @@ -4203,6 +4203,9 @@ out: > return ret; > } > > +#define VXGE_PXE_FIRMWARE "vxge/X3fw-pxe.ncf" > +#define VXGE_FIRMWARE "vxge/X3fw.ncf" > + > static int vxge_probe_fw_update(struct vxgedev *vdev) > { > u32 maj, min, bld; > @@ -4245,9 +4248,9 @@ static int vxge_probe_fw_update(struct vxgedev *vdev) > } > } > if (gpxe) > - fw_name = "vxge/X3fw-pxe.ncf"; > + fw_name = VXGE_PXE_FIRMWARE; > else > - fw_name = "vxge/X3fw.ncf"; > + fw_name = VXGE_FIRMWARE; > > ret = vxge_fw_upgrade(vdev, fw_name, 0); > /* -EINVAL and -ENOENT are not fatal errors for flashing firmware on > @@ -4855,3 +4858,5 @@ vxge_closer(void) > } > module_init(vxge_starter); > module_exit(vxge_closer); > +MODULE_FIRMWARE(VXGE_PXE_FIRMWARE); > +MODULE_FIRMWARE(VXGE_FIRMWARE); IIUC, MODULE_FIRMWARE is only necessary for devices that need firmware to operate. vxge hardware has an image in flash on the nic, and the modified code is used to update the firmware image on the adapter. So, this change isn't doing what you want it to do. Also, wasn't this already discussed (https://lkml.org/lkml/2012/4/12/401)? Thanks, Jon > -- > 1.7.9.5 >