From: Jon Mason <jdmason@kudzu.us>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Christian Benvenuti <benve@cisco.com>,
Neel Patel <neepatel@cisco.com>,
Nishank Trivedi <nistrive@cisco.com>
Subject: Re: [PATCH 02/11] enic: remove unnecessary setting of skb->dev
Date: Thu, 12 Jul 2012 14:19:16 -0700 [thread overview]
Message-ID: <CAPoiz9y2D15o4ueTCWPQHiNHexBVXSABO_1ghpKtYCruSDV-Ew@mail.gmail.com> (raw)
In-Reply-To: <1341878975-10577-2-git-send-email-jdmason@kudzu.us>
On Mon, Jul 9, 2012 at 5:09 PM, Jon Mason <jdmason@kudzu.us> wrote:
> skb->dev is being unnecessarily set after calling eth_type_trans.
> eth_type_trans already sets skb->dev to the proper value, thus making this
> unnecessary.
>
> Signed-off-by: Jon Mason <jdmason@kudzu.us>
> Cc: Christian Benvenuti <benve@cisco.com>
> Cc: Roopa Prabhu <roprabhu@cisco.com>
This address bounced. Anyone know of an updated address for Roopa or
should they be removed from the MAINTAINERS list?
> Cc: Neel Patel <neepatel@cisco.com>
> Cc: Nishank Trivedi <nistrive@cisco.com>
> ---
> drivers/net/ethernet/cisco/enic/enic_main.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
> index 8132c78..ad1468b 100644
> --- a/drivers/net/ethernet/cisco/enic/enic_main.c
> +++ b/drivers/net/ethernet/cisco/enic/enic_main.c
> @@ -1300,8 +1300,6 @@ static void enic_rq_indicate_buf(struct vnic_rq *rq,
> skb->ip_summed = CHECKSUM_COMPLETE;
> }
>
> - skb->dev = netdev;
> -
> if (vlan_stripped)
> __vlan_hwaccel_put_tag(skb, vlan_tci);
>
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2012-07-12 21:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 0:09 [PATCH 01/11] lance: remove unnecessary setting of skb->dev Jon Mason
2012-07-10 0:09 ` [PATCH 02/11] enic: " Jon Mason
2012-07-12 21:19 ` Jon Mason [this message]
2012-07-12 21:23 ` Christian Benvenuti (benve)
2012-07-13 4:56 ` Neel Patel (neepatel)
2012-07-10 0:09 ` [PATCH 03/11] netxen: " Jon Mason
2012-07-10 0:09 ` [PATCH 04/11] lantiq_etop: " Jon Mason
2012-07-10 0:09 ` [PATCH 05/11] ksz884x: " Jon Mason
2012-07-10 0:09 ` [PATCH 06/11] qlcnic: " Jon Mason
2012-07-10 0:09 ` [PATCH 07/11] qlge: " Jon Mason
2012-07-10 0:09 ` [PATCH 08/11] sunbmac: " Jon Mason
2012-07-10 0:09 ` [PATCH 09/11] sungem: " Jon Mason
2012-07-10 0:09 ` [PATCH 10/11] sunhme: " Jon Mason
2012-07-10 0:09 ` [PATCH 11/11] ll_temac: " Jon Mason
2012-07-11 6:18 ` [PATCH 01/11] lance: " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPoiz9y2D15o4ueTCWPQHiNHexBVXSABO_1ghpKtYCruSDV-Ew@mail.gmail.com \
--to=jdmason@kudzu.us \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=neepatel@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=nistrive@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).