From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E2BAC433EF for ; Wed, 27 Apr 2022 17:38:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244183AbiD0Rlg (ORCPT ); Wed, 27 Apr 2022 13:41:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244160AbiD0Rlg (ORCPT ); Wed, 27 Apr 2022 13:41:36 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9622E5BD14 for ; Wed, 27 Apr 2022 10:38:23 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id bq30so4434352lfb.3 for ; Wed, 27 Apr 2022 10:38:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=d4ythIy+4BMKhrFRBWTelImtvnFliKqEsbPbAXakWNA=; b=Rxz8TwmTciAgk1vS6UVXjQfgsSd8NJiPicC44NHYEYvHeQX7PQS/0HS2mJ+k7bNa84 x53Unulgrzln1EX8siAcPHSTO3dO3fw/ORCo2UB0bhnxc8u4lR5UHlgeSUMqHYw90idd L7js8ruFeWcajOx0UHQaehE+rXPO8+cDUZWtzEy0Lr+m7YSOJw6QQEE9A19CP1f+zUUa WFWm5YgxUnybu3a29ZGqv0LhOKHlq+71fNx+PBKNh8W5eN6cYmQnkB9pD7hxF9G4VW0J IAKPDEF3vHBYHAf4mz7EsiokQlwOoV3fWtKYbJsM5Zz/rpeAMqZP+0KkHpwrztvekH6/ ly7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=d4ythIy+4BMKhrFRBWTelImtvnFliKqEsbPbAXakWNA=; b=Nk8ICutH9qtPAF6LO3Hss8/vUivmEnfGwWI6JrB6/2M/RM6JG8oxyhms1bzlDlQmJ1 BMDu553CBdpfLCbIhAXdCH3KsFxGxraBcVULMfl2B6p83d8wJEfsExoILfc6VKnjdOAr kNXe/B7cuwxkXeflvUX/C/bn9dF40LpkaZ0Sdv2zpec7+9TmwCp9N2UJvdM52KVcRl8D BIXSTKEG5fD9OiEOIHvHDR24OnNY1AoFRmtmGxURIvU+BWNrxqRwDasy0QuVWLLACYkZ e0QfV6+EoIyXaRpHDdnEcF3I75xVzzbuYGp0koVJsthMN4EAczJwprT5V+4FsT8cfxZ6 M1Ow== X-Gm-Message-State: AOAM533m7xiQGiXcrPd7hHvb0pYN9jMw0/3WEKeM+76CuETTkRvqgsQM 6BAPX4DSDvqgbpeGbufy9DR0pQugvBg6wQOcj8oVug== X-Google-Smtp-Source: ABdhPJwUwyoKDXmd/Qnsb0PVaPczo3M9ZqbxWCO8Yi39M/Y51Dl62QA24fZkYYZ77+w8PmuO+NTXk881VpoPaApgnfY= X-Received: by 2002:a05:6512:3f89:b0:44a:f5bf:ec7e with SMTP id x9-20020a0565123f8900b0044af5bfec7emr21200622lfa.671.1651081101604; Wed, 27 Apr 2022 10:38:21 -0700 (PDT) MIME-Version: 1.0 References: <20220425094708.2769275-1-mw@semihalf.com> <20220427172514.n4musn42dhygzbu2@skbuf> In-Reply-To: <20220427172514.n4musn42dhygzbu2@skbuf> From: Marcin Wojtas Date: Wed, 27 Apr 2022 19:38:09 +0200 Message-ID: Subject: Re: [net: PATCH] net: dsa: add missing refcount decrementation To: Vladimir Oltean Cc: Linux Kernel Mailing List , netdev , "David S. Miller" , Jakub Kicinski , Andrew Lunn , vivien.didelot@gmail.com, Florian Fainelli , upstream@semihalf.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org =C5=9Br., 27 kwi 2022 o 19:25 Vladimir Oltean napisa=C5= =82(a): > > On Mon, Apr 25, 2022 at 11:47:08AM +0200, Marcin Wojtas wrote: > > After obtaining the "phy-handle" node, decrementing > > refcount is required. Fix that. > > > > Fixes: a20f997010c4 ("net: dsa: Don't instantiate phylink for CPU/DSA p= orts unless needed") > > Signed-off-by: Marcin Wojtas > > --- > > net/dsa/port.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/net/dsa/port.c b/net/dsa/port.c > > index 32d472a82241..cdc56ba11f52 100644 > > --- a/net/dsa/port.c > > +++ b/net/dsa/port.c > > @@ -1620,8 +1620,10 @@ int dsa_port_link_register_of(struct dsa_port *d= p) > > if (ds->ops->phylink_mac_link_down) > > ds->ops->phylink_mac_link_down(ds, port, > > MLO_AN_FIXED, PHY_INTERFACE_MODE_= NA); > > + of_node_put(phy_np); > > return dsa_port_phylink_register(dp); > > } > > + of_node_put(phy_np); > > return 0; > > } > > > > -- > > 2.29.0 > > > > Thanks for the patch. > > commit fc06b2867f4cea543505acfb194c2be4ebf0c7d3 > Author: Miaoqian Lin > Date: Wed Apr 20 19:04:08 2022 +0800 > > net: dsa: Add missing of_node_put() in dsa_port_link_register_of > > The device_node pointer is returned by of_parse_phandle() with refco= unt > incremented. We should use of_node_put() on it when done. > of_node_put() will check for NULL value. > > Fixes: a20f997010c4 ("net: dsa: Don't instantiate phylink for CPU/DSA= ports unless needed") > Signed-off-by: Miaoqian Lin > Signed-off-by: David S. Miller Great, I'll rebase then and I can drop my patch. Thanks, Marcin