netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcin Wojtas <mw@semihalf.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Baruch Siach <baruch@tkos.co.il>,
	Russell King <linux@armlinux.org.uk>,
	netdev <netdev@vger.kernel.org>,
	Baruch Siach <baruch.siach@siklu.com>
Subject: Re: [PATCH] net: mvpp2: add delay at the end of .mac_prepare
Date: Thu, 28 Apr 2022 18:29:02 +0200	[thread overview]
Message-ID: <CAPv3WKfdJ5cM_-Mm7cHHXJJehQo9tTbJtGnU36D464Syu4zFkQ@mail.gmail.com> (raw)
In-Reply-To: <20220428072803.76490cbd@kernel.org>

Hi Jakub,

czw., 28 kwi 2022 o 16:28 Jakub Kicinski <kuba@kernel.org> napisał(a):
>
> On Wed, 27 Apr 2022 18:05:36 +0300 Baruch Siach wrote:
> > From: Baruch Siach <baruch.siach@siklu.com>
> >
> > Without this delay PHY mode switch from XLG to SGMII fails in a weird
> > way. Rx side works. However, Tx appears to work as far as the MAC is
> > concerned, but packets don't show up on the wire.
> >
> > Tested with Marvell 10G 88X3310 PHY.
> >
> > Signed-off-by: Baruch Siach <baruch.siach@siklu.com>
> > ---
> >
> > Not sure this is the right fix. Let me know if you have any better
> > suggestion for me to test.
> >
> > The same issue and fix reproduce with both v5.18-rc4 and v5.10.110.
>
> Let me mark it as RFC in patchwork, then. If the discussion concludes
> with an approval please repost as [PATCH net] and preferably with a
> Fixes tag; failing that a stable tag, since you indicate 5.10 needs it.

Please do, that's a good idea.

Thanks,
Marcin

  reply	other threads:[~2022-04-28 16:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27 15:05 [PATCH] net: mvpp2: add delay at the end of .mac_prepare Baruch Siach
2022-04-28  8:59 ` Marcin Wojtas
2022-04-28 10:59   ` Baruch Siach
2022-04-28 16:38     ` Marcin Wojtas
2022-04-28 20:03       ` Baruch Siach
2022-05-01  7:46         ` Baruch Siach
2022-05-01  8:23           ` Marcin Wojtas
2022-05-01  8:28             ` Baruch Siach
2022-05-01 11:44         ` Russell King (Oracle)
2022-05-01 11:45           ` Baruch Siach
2022-05-01 11:37     ` Russell King (Oracle)
2022-05-01 11:34   ` Russell King (Oracle)
2022-04-28 14:28 ` Jakub Kicinski
2022-04-28 16:29   ` Marcin Wojtas [this message]
2022-05-01 11:30 ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPv3WKfdJ5cM_-Mm7cHHXJJehQo9tTbJtGnU36D464Syu4zFkQ@mail.gmail.com \
    --to=mw@semihalf.com \
    --cc=baruch.siach@siklu.com \
    --cc=baruch@tkos.co.il \
    --cc=kuba@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).