From: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Dept-NX Linux NIC Driver <Dept_NX_Linux_NIC_Driver@qlogic.com>,
Manish Chopra <manish.chopra@qlogic.com>
Subject: Re: [PATCH net-next] ethtool: Added a field fw dump_state
Date: Fri, 16 Mar 2012 14:28:03 -0700 [thread overview]
Message-ID: <CB88FD74.2A201%anirban.chakraborty@qlogic.com> (raw)
In-Reply-To: <1331932962.19406.23.camel@edumazet-glaptop>
On 3/16/12 2:22 PM, "Eric Dumazet" <eric.dumazet@gmail.com> wrote:
>On Fri, 2012-03-16 at 14:10 -0700, Anirban Chakraborty wrote:
>>
>> On 3/16/12 11:27 AM, "Ben Hutchings" <bhutchings@solarflare.com> wrote:
>>
>> >On Fri, 2012-03-16 at 10:58 -0700, Anirban Chakraborty wrote:
>> >> +
>> >> struct ethtool_dump {
>> >> __u32 cmd;
>> >> __u32 version;
>> >> __u32 flag;
>> >> __u32 len;
>> >> __u8 data[0];
>> >> + __u8 dump_state;
>> >
>> >Don't be ridiculous.
>>
>> Yeah I know, especially when there is a flag field already present
>>there.
>> The only
>> reason, we considered for adding it is to keep the backward
>>compatibility
>> of scripts.
>> Right now, the flag field sets/gets the dump level of fw. If we use it
>>to
>> control the
>> dump state, then it would break the existing scripts, if there are any.
>>
>
>You missed the point... data[0] must be the last element in the
>structure.
Yes, that was wrong struct. Sorry, I should have caught it earlier. We'll
resend it.
-Anirban
next prev parent reply other threads:[~2012-03-16 21:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 17:58 [PATCH net-next] ethtool: Added a field fw dump_state Anirban Chakraborty
2012-03-16 17:58 ` [PATCH net-next] qlcnic: ethtool change to provide the dump_state information Anirban Chakraborty
2012-03-16 18:27 ` [PATCH net-next] ethtool: Added a field fw dump_state Ben Hutchings
2012-03-16 21:10 ` Anirban Chakraborty
2012-03-16 21:22 ` Eric Dumazet
2012-03-16 21:28 ` Anirban Chakraborty [this message]
2012-03-16 21:37 ` Ben Hutchings
2012-03-16 22:37 ` Anirban Chakraborty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB88FD74.2A201%anirban.chakraborty@qlogic.com \
--to=anirban.chakraborty@qlogic.com \
--cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=manish.chopra@qlogic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).