From: "Vick, Matthew" <matthew.vick@intel.com>
To: Jakub Kicinski <kubakici@wp.pl>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>
Subject: Re: [PATCH net-next 4/4] igb: fix last_rx_timestamp usage
Date: Thu, 3 Apr 2014 15:20:52 +0000 [thread overview]
Message-ID: <CF62C97F.43F0F%matthew.vick@intel.com> (raw)
In-Reply-To: <1396399939-18420-5-git-send-email-kubakici@wp.pl>
On 4/1/14, 5:52 PM, "Jakub Kicinski" <kubakici@wp.pl> wrote:
>last_rx_timestamp should be updated only when rx time stamp is
>read. Also it's only used with NICs that have per-interface time
>stamping resources so it can be moved to adapter structure and
>set in igb_ptp_rx_rgtstamp().
>
>Signed-off-by: Jakub Kicinski <kubakici@wp.pl>
Looks good to me, Jakub. Thanks for doing this work!
Acked-by: Matthew Vick <matthew.vick@intel.com>
next prev parent reply other threads:[~2014-04-03 15:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 0:52 [PATCH net-next 0/4] intel: string and rx tstamping cleanups Jakub Kicinski
2014-04-02 0:52 ` [PATCH net-next 1/4] e1000: remove debug messages with function names Jakub Kicinski
2014-04-02 1:45 ` Jeff Kirsher
2014-04-02 0:52 ` [PATCH net-next 2/4] e1000e/igb/ixgbe/i40e: fix message terminations Jakub Kicinski
2014-04-02 1:45 ` Jeff Kirsher
2014-04-02 0:52 ` [PATCH net-next 3/4] ixgbe: clean up rx time stamping code Jakub Kicinski
2014-04-02 1:45 ` Jeff Kirsher
2014-04-02 0:52 ` [PATCH net-next 4/4] igb: fix last_rx_timestamp usage Jakub Kicinski
2014-04-02 1:46 ` Jeff Kirsher
2014-04-03 15:20 ` Vick, Matthew [this message]
2014-04-02 1:44 ` [PATCH net-next 0/4] intel: string and rx tstamping cleanups Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CF62C97F.43F0F%matthew.vick@intel.com \
--to=matthew.vick@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kubakici@wp.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).