Netdev List
 help / color / mirror / Atom feed
From: "Hawkins, Nick" <nick.hawkins@hpe.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
	"simon.horman@corigine.com" <simon.horman@corigine.com>,
	"Verdun, Jean-Marie" <verdun@hpe.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/5] net: hpe: Add GXP UMAC Driver
Date: Tue, 22 Aug 2023 19:00:49 +0000	[thread overview]
Message-ID: <CF9BD927-B788-4554-B246-D5CC6D06258F@hpe.com> (raw)
In-Reply-To: <1b8058e1-6e7f-4a4a-a191-09a9b8010e0a@lunn.ch>


> <include/net/page_pool/helpers.h>

Hi Andrew,

I can't seem to find this file in linux master. Where is it?

> Take a look at driver/net/ethernet/freescale/fec_main.c That
> driver/device is of similar complexity to yours. It had a recent
> change from its own buffer management to page pool. It
> started with

I have looked over this driver and have a couple questions
about the pages in general.

How do I determine what the correct pool size should be for the
RX and TX?

I must admit I am not familiar with XDP.
Is it required for the page pool library? Does it require any kind
of hardware enablement? Or is it just purely code?

Thanks for the feedback and assistance,

-Nick Hawkins


  reply	other threads:[~2023-08-22 19:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-16 21:52 [PATCH v3 0/5] ARM: Add GXP UMAC Support nick.hawkins
2023-08-16 21:52 ` [PATCH v3 1/5] dt-bindings: net: Add HPE GXP UMAC MDIO nick.hawkins
2023-08-17  1:10   ` Andrew Lunn
2023-08-16 21:52 ` [PATCH v3 2/5] net: hpe: Add " nick.hawkins
2023-08-17  1:19   ` Andrew Lunn
2023-08-16 21:52 ` [PATCH v3 3/5] dt-bindings: net: Add HPE GXP UMAC nick.hawkins
2023-08-17  8:53   ` Conor Dooley
2023-08-16 21:52 ` [PATCH v3 4/5] net: hpe: Add GXP UMAC Driver nick.hawkins
2023-08-17  1:46   ` Andrew Lunn
2023-08-17 19:19     ` Hawkins, Nick
2023-08-17 19:44       ` Andrew Lunn
2023-08-18 20:11     ` Hawkins, Nick
2023-08-18 21:15       ` Andrew Lunn
2023-08-22 19:00         ` Hawkins, Nick [this message]
2023-08-22 20:00           ` Andrew Lunn
2023-08-25 18:54             ` Hawkins, Nick
2023-09-04  3:58               ` Andrew Lunn
2023-09-11 21:12                 ` Hawkins, Nick
2023-09-12 23:52                   ` Andrew Lunn
2023-08-17  7:45   ` Simon Horman
2023-08-16 21:52 ` [PATCH v3 5/5] MAINTAINERS: HPE: Add GXP UMAC Networking Files nick.hawkins
2023-08-17  1:47   ` Andrew Lunn
2023-08-17  1:08 ` [PATCH v3 0/5] ARM: Add GXP UMAC Support Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CF9BD927-B788-4554-B246-D5CC6D06258F@hpe.com \
    --to=nick.hawkins@hpe.com \
    --cc=andrew@lunn.ch \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh+dt@kernel.org \
    --cc=simon.horman@corigine.com \
    --cc=verdun@hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox