Netdev List
 help / color / mirror / Atom feed
From: Jamal Hadi Salim <jhs@mojatatu.com>
To: netdev@vger.kernel.org
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
	Jiri Pirko <jiri@resnulli.us>,
	Victor Nogueira <victor@mojatatu.com>
Subject: [PATCH net-next 0/1] net: neighbour: skip the stale dst lookup for a redirected skb
Date: Fri, 20 Nov 2026 10:42:58 -0500	[thread overview]
Message-ID: <CORE-J9UK.v1.r0.20261120103344@mojatatu.com> (raw)

This replaces the four-patch series posted as [PATCH net-next v4 0/4]
"net: drop the stale dst when steering to another device":

https://lore.kernel.org/netdev/CORE-9NOG.v4.r0.20261116135311@mojatatu.com/

Patches 2/4, 3/4 and 4/4 are withdrawn, and 1/4 is split out into a
separate posting against net:

  * 2/4, 3/4 and 4/4 dropped the stale dst at each producer that steers a
    packet to another device. Alexei Starovoitov pointed out that a route
    for one device is a normal thing to find on a frame that leaves
    another one, and that the xfrm, tunnel and lwtstate consumers further
    down still need it, so they are gone.

  * 1/4 is a regression of the xfrm interface helper, so it goes to net
    on its own.

What is left is the drain guard Alexei proposed in his review of v4:

https://lore.kernel.org/netdev/DMX7RM93TMGR.AXFN4YJ55REF@gmail.com/

It is adopted as written: neigh_update_process_arp_queue() skips the
re-lookup of the neighbour from the skb's dst when skb->dev is already
neigh->dev. The parking neighbour is the top-level one in that case and
can reinject the frame itself; a dst that is a route via another device,
which is the sch_teql shape, still takes the lookup.


Jamal Hadi Salim (1):
  net: neighbour: skip the stale dst lookup for a redirected skb

 net/core/neighbour.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
2.43.0


             reply	other threads:[~2026-11-20 15:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 15:42 Jamal Hadi Salim [this message]
2026-11-20 15:42 ` [PATCH net-next 1/1] net: neighbour: skip the stale dst lookup for a redirected skb Jamal Hadi Salim
2026-11-20 15:47 ` [PATCH net-next 0/1] " netdev-bot+sinfo
2026-11-20 16:05   ` Jamal Hadi Salim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CORE-J9UK.v1.r0.20261120103344@mojatatu.com \
    --to=jhs@mojatatu.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=victor@mojatatu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox