From: "Vincenzo Palazzo" <vincenzopalazzodev@gmail.com>
To: "Jakub Kicinski" <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<intel-wired-lan@lists.osuosl.org>, <jesse.brandeburg@intel.com>,
<khc@pm.waw.pl>, "kernel test robot" <lkp@intel.com>
Subject: Re: [PATCH v3] netdevice: use ifmap instead of plain fields
Date: Sat, 04 Mar 2023 20:33:38 +0100 [thread overview]
Message-ID: <CQXUM7MRJU3X.321CXIWRLP8ZL@vincent-arch> (raw)
In-Reply-To: <20230304110641.6467996b@kernel.org>
On Sat Mar 4, 2023 at 8:06 PM CET, Jakub Kicinski wrote:
> On Sat, 4 Mar 2023 12:56:26 +0100 Vincenzo Palazzo wrote:
> > clean the code by using the ifmap instead of plain fields,
> > and avoid code duplication.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Link: https://lore.kernel.org/oe-kbuild-all/202303041847.nRrrz1v9-lkp@intel.com/
> > Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
>
> Please don't, as already explained it's not worth the code churn.
Ah! ok I got it, yes maybe this should be an RFC, I thought also that
this change will impact in so many things!
Ok, so I will remove just the FIXME that at this point is not
useful anymore.
Cheers!
Vincent.
prev parent reply other threads:[~2023-03-04 19:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-04 11:56 [PATCH v3] netdevice: use ifmap instead of plain fields Vincenzo Palazzo
2023-03-04 14:33 ` kernel test robot
2023-03-04 14:44 ` kernel test robot
2023-03-04 15:05 ` kernel test robot
2023-03-04 19:06 ` Jakub Kicinski
2023-03-04 19:33 ` Vincenzo Palazzo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CQXUM7MRJU3X.321CXIWRLP8ZL@vincent-arch \
--to=vincenzopalazzodev@gmail.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=khc@pm.waw.pl \
--cc=kuba@kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).