From: <Steen.Hegelund@microchip.com>
To: <peter_hong@fintek.com.tw>, <wg@grandegger.com>, <mkl@pengutronix.de>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <mailhol.vincent@wanadoo.fr>,
<frank.jungclaus@esd.eu>, <linux-kernel@vger.kernel.org>,
<linux-can@vger.kernel.org>, <netdev@vger.kernel.org>,
<hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH] can: usb: f81604: add Fintek F81604 support
Date: Mon, 20 Mar 2023 10:21:07 +0000 [thread overview]
Message-ID: <CRB4VW859JPC.253TLOWY0XT6S@den-dk-m31857> (raw)
In-Reply-To: <20230317093352.3979-1-peter_hong@fintek.com.tw>
Hi Peter,
Besides what Michal has mentioned, I noted this:
On Fri Mar 17, 2023 at 10:33 AM CET, Ji-Ze Hong (Peter Hong) wrote:
> [Some people who received this message don't often get email from peter_hong@fintek.com.tw. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> This patch add support for Fintek USB to 2CAN controller support.
>
> Signed-off-by: Ji-Ze Hong (Peter Hong) <peter_hong@fintek.com.tw>
> ---
..snip...
> +static int f81604_prepare_urbs(struct net_device *netdev)
> +{
> + static u8 bulk_in_addr[F81604_MAX_DEV] = { 0x82, 0x84 };
> + static u8 bulk_out_addr[F81604_MAX_DEV] = { 0x01, 0x03 };
> + static u8 int_in_addr[F81604_MAX_DEV] = { 0x81, 0x83 };
These 3 should be made const
> + struct f81604_port_priv *priv;
> + int id;
..snip...
> + int i;
> +MODULE_AUTHOR("Ji-Ze Hong (Peter Hong) <peter_hong@fintek.com.tw>");
> +MODULE_DESCRIPTION("Fintek F81604 USB to 2xCANBUS");
> +MODULE_LICENSE("GPL");
> --
> 2.17.1
BR
Steen
prev parent reply other threads:[~2023-03-20 10:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 9:33 [PATCH] can: usb: f81604: add Fintek F81604 support Ji-Ze Hong (Peter Hong)
2023-03-17 13:15 ` Michal Swiatkowski
2023-03-20 2:59 ` Peter Hong
2023-03-20 7:24 ` Michal Swiatkowski
2023-03-20 10:21 ` Steen.Hegelund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CRB4VW859JPC.253TLOWY0XT6S@den-dk-m31857 \
--to=steen.hegelund@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=frank.jungclaus@esd.eu \
--cc=hpeter+linux_kernel@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peter_hong@fintek.com.tw \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox