From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38B774A0A; Mon, 26 May 2025 23:07:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748300827; cv=none; b=cGZJleOzLvryrq8DZ1vWtmbNp9zbgKApqdU0pzqHPZCrT/ckneYSdu8YxgTQ/7Drt+vJ0blcbxPYqBBMoj13fgqTSp+ibsKzgnhRcF+LQx40QT3HOOZs+SI+tKmwbCtKMzhRXUXZdNoHWqgEAZDx1E4tlHcML96zd5O1uh37f94= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748300827; c=relaxed/simple; bh=4GTm92/StxP3CBkdP9+oBFRRK5sAn5a+30xV9eMTjdU=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=dZQMYB96wnZozZyoNKZsIdk6RzyaFZMNOVLhK1RA//b+SPOE5LQ13xklUHnK0Dl/fFHaT6HNkCKG5rp8o61ad+h2tdbOQaYZltC7MUV6QI+LTpzIL5Dis+7CqNh7x99gHxlFijs1H68mH84Wi/8ch2KvL8mKj/5jcCUj7rIxDCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hmnhKAlk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hmnhKAlk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FFA7C4CEE7; Mon, 26 May 2025 23:06:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748300826; bh=4GTm92/StxP3CBkdP9+oBFRRK5sAn5a+30xV9eMTjdU=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=hmnhKAlkvuE2emSj9dfAfZcutKdfVzcU9bHAsmsJM0Zdbg+V3tiZL4LWoWqx3jK1j 3W6J1AiBX0jOVwW6Uu1l0coUJkbN0O0ub5j8wJo2M9UXwM5vZXNBD9kvVh9tq8uHsq gLBAxelbgU8kLF9pUNkSdyvxKo/nMlcwAuEGO5BmfY0GFTGnOyUUIaOZL2F3dZHH3O nnnM/URug0l9b4XyH0WCyhIzfOi+i6T0vfoSkCnTGQv2MEdZ0ix2Gw5r8+kcePcIAB Uabc3hOKze8/XRm5QNUyIsnrUQBNoPOTwHuuWxMU2qSqGW4cGQwCFJK7RhFJovfi+z ScfsK7T/pbYzA== Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 27 May 2025 01:06:54 +0200 Message-Id: Subject: Re: [PATCH v10 4/5] rust: replace `kernel::c_str!` with C-Strings From: "Benno Lossin" To: "Tamir Duberstein" Cc: "Michal Rostecki" , "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Andreas Hindborg" , "Alice Ryhl" , "Trevor Gross" , "Brendan Higgins" , "David Gow" , "Rae Moar" , "Danilo Krummrich" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Greg Kroah-Hartman" , "Rafael J. Wysocki" , "Luis Chamberlain" , "Russ Weight" , "FUJITA Tomonori" , "Rob Herring" , "Saravana Kannan" , "Peter Zijlstra" , "Ingo Molnar" , "Will Deacon" , "Waiman Long" , "Nathan Chancellor" , "Nick Desaulniers" , "Bill Wendling" , "Justin Stitt" , "Andrew Lunn" , "Heiner Kallweit" , "Russell King" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Bjorn Helgaas" , "Arnd Bergmann" , "Jens Axboe" , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , , , , , , , , , , , X-Mailer: aerc 0.20.1 References: <20250524-cstr-core-v10-0-6412a94d9d75@gmail.com> <20250524-cstr-core-v10-4-6412a94d9d75@gmail.com> In-Reply-To: On Tue May 27, 2025 at 12:29 AM CEST, Tamir Duberstein wrote: > On Mon, May 26, 2025 at 11:04=E2=80=AFAM Benno Lossin = wrote: >> On Sat May 24, 2025 at 10:33 PM CEST, Tamir Duberstein wrote: >> > +macro_rules! c_str_avoid_literals { >> >> I don't like this name, how about `concat_to_c_str` or >> `concat_with_nul`? >> >> This macro also is useful from macros that have a normal string literal, >> but can't turn it into a `c""` one. > > Uh, can you give an example? I'm not attached to the name. There is one in this patch (: diff --git a/rust/kernel/kunit.rs b/rust/kernel/kunit.rs = =20 index e5621d596ed3..09148e982f48 100644 = =20 --- a/rust/kernel/kunit.rs = =20 +++ b/rust/kernel/kunit.rs = =20 @@ -58,9 +58,10 @@ macro_rules! kunit_assert { = =20 break 'out; = =20 } = =20 = =20 - static FILE: &'static $crate::str::CStr =3D $crate::c_str!= ($file); =20 + static FILE: &'static $crate::str::CStr =3D $crate::c_str_= avoid_literals!($file); --- Cheers, Benno