From: John Holland <jotihojr@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob
Date: Wed, 10 Feb 2016 10:16:27 +0100 [thread overview]
Message-ID: <DF83416F-314C-4F27-A649-DD6574A83AE7@gmail.com> (raw)
In-Reply-To: <20160209115921.GE18781@lunn.ch>
On Feb 9, 2016, at 12:59, Andrew Lunn <andrew@lunn.ch> wrote:
>>> + dn = of_find_compatible_node(NULL, NULL, "intel,i211");
>
> Humm, NULL, NULL. That means find the first node anywhere in the
> device tree which matches. This is not going to work too well when you
> have multiple i211s.
>
> There is a way so specify a DT node is attached to a specific PCIe
> bus/slot. I think you should search only there, so solving the
> multiple device issue.
>
Good point. Will specify the current PCIe node.
next prev parent reply other threads:[~2016-02-10 9:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 22:11 [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob John Holland
2016-02-09 11:02 ` Jeff Kirsher
2016-02-09 11:54 ` Andrew Lunn
2016-02-10 9:13 ` John Holland
2016-02-10 16:59 ` Andrew Lunn
2016-02-09 11:59 ` Andrew Lunn
2016-02-09 17:42 ` Shannon Nelson
2016-02-09 22:10 ` David Miller
2016-02-10 8:50 ` John Holland
2016-02-10 9:16 ` John Holland [this message]
2016-02-10 8:52 ` John Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DF83416F-314C-4F27-A649-DD6574A83AE7@gmail.com \
--to=jotihojr@gmail.com \
--cc=andrew@lunn.ch \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).