From: "Théo Lebrun" <theo.lebrun@bootlin.com>
To: "Nicolai Buchwitz" <nb@tipi-net.de>, <netdev@vger.kernel.org>
Cc: andrew+netdev@lunn.ch, claudiu.beznea@tuxon.dev,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
nicolas.ferre@microchip.com, pabeni@redhat.com,
linux@armlinux.org.uk, phil@raspberrypi.com,
"Grégory Clement" <gregory.clement@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 1/5] net: cadence: macb: add EEE register definitions and capability flag
Date: Wed, 25 Feb 2026 18:26:18 +0100 [thread overview]
Message-ID: <DGO7VZMIEFXR.1XGID5EK3Y72A@bootlin.com> (raw)
In-Reply-To: <20260225091558.51157-2-nb@tipi-net.de>
Hello Nicolai,
On Wed Feb 25, 2026 at 10:15 AM CET, Nicolai Buchwitz wrote:
> Add register and bitfield definitions for the Cadence GEM MAC's
> IEEE 802.3az Energy Efficient Ethernet (EEE) support:
nit: could this patch be squashed into [3/5]?
> - LPI statistics counter registers (GEM_RXLPI, GEM_RXLPITIME,
> GEM_TXLPI, GEM_TXLPITIME) at offsets 0x270-0x27c
> - TX LPI enable bitfield (GEM_TXLPIEN) in the NCR register (bit 19),
> which directly asserts/deasserts LPI on the transmit path
> - MACB_CAPS_EEE capability flag to gate EEE support per platform
>
> These registers are present in all Cadence GEM revisions that support
> EEE (verified on SAMA5D2, SAME70, PIC32CZ, and RP1 variants).
Would the capability flag deserve to be added to any other compatible?
Thanks,
--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-02-25 17:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 9:15 [PATCH net-next v3 0/5] net: cadence: macb: add IEEE 802.3az EEE support Nicolai Buchwitz
2026-02-25 9:15 ` [PATCH 1/5] net: cadence: macb: add EEE register definitions and capability flag Nicolai Buchwitz
2026-02-25 17:26 ` Théo Lebrun [this message]
2026-02-26 1:49 ` Jakub Kicinski
2026-02-25 9:15 ` [PATCH 2/5] net: cadence: macb: add EEE LPI statistics counters Nicolai Buchwitz
2026-02-25 9:15 ` [PATCH 3/5] net: cadence: macb: implement EEE TX LPI support Nicolai Buchwitz
2026-02-25 17:32 ` Sai Krishna Gajula
2026-02-26 8:01 ` Nicolai Buchwitz
2026-02-25 17:42 ` Théo Lebrun
2026-02-25 17:50 ` Russell King (Oracle)
2026-02-26 9:52 ` Théo Lebrun
2026-02-26 10:49 ` Nicolai Buchwitz
2026-02-26 13:50 ` Théo Lebrun
2026-02-27 9:00 ` Nicolai Buchwitz
2026-02-27 14:39 ` Théo Lebrun
2026-02-25 9:15 ` [PATCH 4/5] net: cadence: macb: add ethtool EEE support Nicolai Buchwitz
2026-02-25 9:15 ` [PATCH 5/5] net: cadence: macb: enable EEE for Raspberry Pi RP1 Nicolai Buchwitz
2026-02-25 10:56 ` [PATCH net-next v3 0/5] net: cadence: macb: add IEEE 802.3az EEE support Nicolai Buchwitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGO7VZMIEFXR.1XGID5EK3Y72A@bootlin.com \
--to=theo.lebrun@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregory.clement@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=phil@raspberrypi.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox