public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: "Théo Lebrun" <theo.lebrun@bootlin.com>
To: "Nicolai Buchwitz" <nb@tipi-net.de>,
	"Théo Lebrun" <theo.lebrun@bootlin.com>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>,
	netdev@vger.kernel.org, andrew+netdev@lunn.ch,
	claudiu.beznea@tuxon.dev, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org,
	nicolas.ferre@microchip.com, pabeni@redhat.com,
	phil@raspberrypi.com,
	"Grégory Clement" <gregory.clement@bootlin.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 3/5] net: cadence: macb: implement EEE TX LPI support
Date: Fri, 27 Feb 2026 15:39:09 +0100	[thread overview]
Message-ID: <DGPTL3ER0WFH.FA79BTCTCWDO@bootlin.com> (raw)
In-Reply-To: <e90dc9e1ac7c9d85607c8fad6094d6b2@tipi-net.de>

Hello Nicolai,

On Fri Feb 27, 2026 at 10:00 AM CET, Nicolai Buchwitz wrote:
> On 26.2.2026 14:50, Théo Lebrun wrote:
>> On Thu Feb 26, 2026 at 11:49 AM CET, Nicolai Buchwitz wrote:
>> But talking about perf, let's measure.
>
> Tthanks for testing! Since you have the hardware at hand, would you be 
> willing to add MACB_CAPS_EEE to eyeq5_config as well? I'm happy to 
> include it in the series if you can confirm it works correctly.

Tested-by: Théo Lebrun <theo.lebrun@bootlin.com>

Tested using a hardware loopback and a net namespace.

# ip netns add netns_eth1
# ip link set eth1 netns netns_eth1
# ip -n netns_eth1 a add 10.0.0.2/24 dev eth1
# ip -n netns_eth1 link set eth1 up
# ip a add 10.0.0.1/24 dev eth0
# ip link set eth0 up

... ping and iperf3 ...

# ethtool --show-eee eth0
EEE settings for eth0:
enabled - active
250000 (us)
        Supported EEE link modes:  100baseT/Full
                                   1000baseT/Full
        Advertised EEE link modes:  100baseT/Full
                                    1000baseT/Full
        Link partner advertised EEE link modes:  100baseT/Full
                                                 1000baseT/Full

# ip netns exec netns_eth1 ethtool --show-eee eth1
EEE settings for eth1:
enabled - active
250000 (us)
        Supported EEE link modes:  100baseT/Full
                                   1000baseT/Full
        Advertised EEE link modes:  100baseT/Full
                                    1000baseT/Full
        Link partner advertised EEE link modes:  100baseT/Full
                                                 1000baseT/Full

Thanks,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


  reply	other threads:[~2026-02-27 14:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25  9:15 [PATCH net-next v3 0/5] net: cadence: macb: add IEEE 802.3az EEE support Nicolai Buchwitz
2026-02-25  9:15 ` [PATCH 1/5] net: cadence: macb: add EEE register definitions and capability flag Nicolai Buchwitz
2026-02-25 17:26   ` Théo Lebrun
2026-02-26  1:49     ` Jakub Kicinski
2026-02-25  9:15 ` [PATCH 2/5] net: cadence: macb: add EEE LPI statistics counters Nicolai Buchwitz
2026-02-25  9:15 ` [PATCH 3/5] net: cadence: macb: implement EEE TX LPI support Nicolai Buchwitz
2026-02-25 17:32   ` Sai Krishna Gajula
2026-02-26  8:01     ` Nicolai Buchwitz
2026-02-25 17:42   ` Théo Lebrun
2026-02-25 17:50     ` Russell King (Oracle)
2026-02-26  9:52       ` Théo Lebrun
2026-02-26 10:49         ` Nicolai Buchwitz
2026-02-26 13:50           ` Théo Lebrun
2026-02-27  9:00             ` Nicolai Buchwitz
2026-02-27 14:39               ` Théo Lebrun [this message]
2026-02-25  9:15 ` [PATCH 4/5] net: cadence: macb: add ethtool EEE support Nicolai Buchwitz
2026-02-25  9:15 ` [PATCH 5/5] net: cadence: macb: enable EEE for Raspberry Pi RP1 Nicolai Buchwitz
2026-02-25 10:56 ` [PATCH net-next v3 0/5] net: cadence: macb: add IEEE 802.3az EEE support Nicolai Buchwitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGPTL3ER0WFH.FA79BTCTCWDO@bootlin.com \
    --to=theo.lebrun@bootlin.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gregory.clement@bootlin.com \
    --cc=kuba@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=nb@tipi-net.de \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=pabeni@redhat.com \
    --cc=phil@raspberrypi.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox