public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: "Maximilian Moehl" <maximilian@moehl.eu>
To: "Paolo Abeni" <pabeni@redhat.com>,
	"Maximilian Moehl" <maximilian@moehl.eu>,
	"David S. Miller" <davem@davemloft.net>,
	"David Ahern" <dsahern@kernel.org>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Simon Horman" <horms@kernel.org>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net/ipv6: repeat route lookup with saddr set for ECMP
Date: Tue, 31 Mar 2026 14:50:35 +0200	[thread overview]
Message-ID: <DHGZBEMZ25SW.3LE7U694ND0L0@moehl.eu> (raw)
In-Reply-To: <f73c3cf9-18e9-4109-b173-d6000cb0cf88@redhat.com>

On Mon Mar 30, 2026 at 9:56 AM CEST, Paolo Abeni wrote:
> On 3/29/26 11:12 AM, Maximilian Moehl wrote:
>> diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
>> index 8e2a6b28cea7..465fce51d017 100644
>> --- a/net/ipv6/ip6_output.c
>> +++ b/net/ipv6/ip6_output.c
>> @@ -1148,6 +1148,18 @@ static int ip6_dst_lookup_tail(struct net *net, const struct sock *sk,
>>  			*dst = NULL;
>>  		}
>>  
>> +		/* If ECMP was involved the initial hash was calculted
>> +		 * with saddr=:: which can result in instability
>> +		 * when it is later re-calculated with the selected
>> +		 * saddr. Lookup the route again with the chosen
>> +		 * saddr to get a stable result.
>> +		 */
>> +		if (fl6->mp_hash) {
>> +			fl6->mp_hash = 0;
>> +			dst_release(*dst);
>> +			*dst = NULL;
>> +		}
>> +
>>  		if (fl6->flowi6_oif)
>>  			flags |= RT6_LOOKUP_F_IFACE;
>>  	}
>
> This apparently breaks ipv6 fib tests (fib_tests.sh):
>
> # IPv6 multipath load balance test
> #      TEST: IPv6 multipath loadbalance                          [FAIL]
>
> see
> https://github.com/linux-netdev/nipa/wiki/How-to-run-netdev-selftests-CI-style
> on how to reproduce the tests.
>
> Also this would deserve additional testcases.

Thank you for the pointer, I will look into the tests.

> Without diving much inside the code I have the feeling this change is
> plugged into the wrong place: multipath selection logic should be
> encapsulated by fib6_select_path().

To be able to move this logic into fib6_select_path(), the call to
ip6_route_get_saddr() would probably have to move as well as we need
to set the source address after the first lookup. This would then also
set the source address as a side-effect.

I can give this a try, just want to confirm that it's the correct way
before doing so or if I'm missing something.

--
Max

      reply	other threads:[~2026-03-31 12:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-29  9:12 [PATCH] net/ipv6: repeat route lookup with saddr set for ECMP Maximilian Moehl
2026-03-30  7:56 ` Paolo Abeni
2026-03-31 12:50   ` Maximilian Moehl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHGZBEMZ25SW.3LE7U694ND0L0@moehl.eu \
    --to=maximilian@moehl.eu \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox