From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1B084418D7 for ; Wed, 1 Apr 2026 17:05:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775063132; cv=none; b=hhhjiOafyflWDkbCJF4CSOpAsjH9dEyxm7zWIx1jtFh+Vf90Yvj/0+s+Gtfi72Kzuy08u02Gp5cpTdxMhAfCKRA/+k8Qt/oBC/ugPTp3JazaVTzSjsPDBUiX7xTUu0kyvUXEUr6AFtL/6T7r1sVqT0XfjyK9vA+FYja/y5vu/wE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775063132; c=relaxed/simple; bh=n2jQv47PIrnfO+hHV9FIaP6j1YbNMb5O/ELqKo3CI9s=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=H3cfn1D2lnEu+t4q7zvbamVPcBUHK+dpbAvn7cEuH/MgvMDWDfD8uWcJWsTR1QTp4wfacDL9wIeibQDVaA1l9Yli36Ai0yNXcjzWcw+TnGOQ8PlsxNbkw+qCGHoDnpU4QpPikEv3uFkU//We+O4XX3PFnFTdfsnaahhyqzSrrko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=f9LBBcW2; arc=none smtp.client-ip=91.218.175.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="f9LBBcW2" Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1775063128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n2jQv47PIrnfO+hHV9FIaP6j1YbNMb5O/ELqKo3CI9s=; b=f9LBBcW2Gu2t3reQHiByZTUD2b8Yqr9IPHiTTHXIquQeQo4IzGm+GW7UgNiFDq3X924V6P w15pBGcYNyY8pxkuX8alWqOpP/ciGuf5f9oWFJS9z/S7q8SVJy09ABTUPkjEPEG/9QKSEh wEe0EirH2YVbAtQ1KvQQpQsblWV/kMM= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 01 Apr 2026 19:05:25 +0200 Message-Id: To: "Fernando Fernandez Mancera" , , , , , Cc: , , Subject: Re: [PATCH net-next v4 1/2] net: hsr: require valid EOT supervision TLV X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Luka Gejak" References: <20260401092324.52266-1-luka.gejak@linux.dev> <20260401092324.52266-2-luka.gejak@linux.dev> <4549f521-6395-4c26-921e-eaead7248a36@suse.de> In-Reply-To: <4549f521-6395-4c26-921e-eaead7248a36@suse.de> X-Migadu-Flow: FLOW_OUT On Wed Apr 1, 2026 at 11:52 AM CEST, Fernando Fernandez Mancera wrote: > On 4/1/26 11:23 AM, luka.gejak@linux.dev wrote: >> From: Luka Gejak >>=20 >> Supervision frames are only valid if terminated with a zero-length EOT >> TLV. The current check fails to reject non-EOT entries as the terminal >> TLV, potentially allowing malformed supervision traffic. >>=20 >> Fix this by strictly requiring the terminal TLV to be HSR_TLV_EOT >> with a length of zero. >>=20 >> Reviewed-by: Felix Maurer >> Signed-off-by: Luka Gejak >> --- > > Hi, > > This has not been reviewed by Felix. Felix provided his Reviewed-by tag= =20 > for the v1 which was completely different than this. > > Revisions of this patch: > > v3: https://lore.kernel.org/all/20260329112313.17164-4-luka.gejak@linux.d= ev/ > > v2: https://lore.kernel.org/all/20260326154715.38405-4-luka.gejak@linux.d= ev/ > > v1:=20 > https://lore.kernel.org/all/20260324143503.187642-4-luka.gejak@linux.dev/ > > Are these contributions LLM/AI generated? I believe so based on the=20 > email history. > > AI generated review on rtl8723bs:=20 > https://lore.kernel.org/all/B2394A3C-25FD-4CEA-8557-3E68F1F60357@linux.de= v/ > > Another AI generated review on rtl8723bs:=20 > https://lore.kernel.org/all/3831D599-655E-40B2-9E5D-9DF956013088@linux.de= v/ > > Likely an AI generated review on a 1 year old HSR patch:=20 > https://lore.kernel.org/all/DHFG26KI6L23.1YCOVQ5SSYMO5@linux.dev/ > > If these are indeed, AI generated contributions or reviews they should=20 > be disclosed beforehand. Also there is the Assisted-by: tag. Also note=20 > that developer must take full responsibility for the contribution which= =20 > means understanding it completely. > > https://docs.kernel.org/process/coding-assistants.html#signed-off-by-and-= developer-certificate-of-origin > > Thanks, > Fernando. HI Fernando, One more question, should I include Assisted-by tag in v5 if AI was not=20 used for writing code but only for formating and translation of the=20 emails to English as I previously mentioned. Best regards, Luka Gejak