From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D5B7388392 for ; Sat, 13 Jun 2026 01:31:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781314271; cv=none; b=dMZU30P4cuIq5tnZ8iVhxPdL3Rm2sjQe80BdhrkbwWleQaYgulZb9M8aiWP5s+cvT0O+xvMDHVZPQ3uC9jYzI4x6oQY0nNt/QFT9O944gz0uzc45AiMW1QET+KyOitXYJOu4nWGUEigiHkjA7B8c4OBj58+L2FFD0X16/slbohY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781314271; c=relaxed/simple; bh=o3Ppwk8Pxo2eOnZQYuZg32wpqsbKuSlPC70ZBZfMUGY=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=f38Z3L2K64VFQbhydgS1hrt4YjZ67qqd/ZiS6t9q6fto3p168fdi/0eGP+dmTxoljbR8lg8hPMPgHCYSJgoD4imZfwiOd6y8gaVYA68cDTV9Z+SdMO6rtdmewGeozKJiOgl2sF4MBlMuPSFA0N58y8q6SMeZKVLwyC5UB50zBig= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sD2wrGBW; arc=none smtp.client-ip=209.85.161.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sD2wrGBW" Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-69ed219d3ecso1088225eaf.2 for ; Fri, 12 Jun 2026 18:31:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781314269; x=1781919069; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kG4r8a+egx6Sz73/hv1qlVjU+AH9cIZy42JaiVuxTy4=; b=sD2wrGBW1v1TO4G+NK2K1onVahwaXCkFrFHZNAzpVS9IAQyNzTPDOq/YwDBJqGd+f/ 5d/XDE9xnaHNLWkHeu94SEWDk3QPI/WiH8Nt+rY55B9jN0NCZMf6Q7XRvP97ncq3hjH9 aVC+kFXmUHbHdRwYGVVgIE2jwNMNHcj/QZztqXAAKKHGC7cNdZ4bZ0siUVSVimZRziJc Ct5KqZRdP4LXwA/JQV2aXHxqVpzKU9gK1F7aNV7vJp83Y6Y2PD8goZLSf9VuYZbWCxa/ sBlyDMZv44wY7iajctdXHsvwt9xQ/+b6xenxMIr9wg/+dS6kTTWpYuYWqh7cYOlLEFVb GLfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781314269; x=1781919069; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kG4r8a+egx6Sz73/hv1qlVjU+AH9cIZy42JaiVuxTy4=; b=CHbe3grwnx0kpOwH9sNCo/np3HAsrgLM41AzRroigerEygJpcB7M1w/p3GbLjpvsYm 9nj4AHxLTNObY1WRK2Lvz4jZ4Z0CJZ1kHTVPqQ75x5CT9CCXxQELzbeBMLR3cUJTuAG2 K83PLGn0oiWGLSaIuRoe0cjhqaG11p0caa6AvJhx2wtk0+2JG/w22eW2tnC5CaRxuhfo UODAJHgnNp3aLQCvyFkx7E1cRbdbCv5yjnK/401dBtD7TD45/S1QDDhj8DHzxNb3nS78 mEvk1f83c4gPN25vxA8KQTXedWcWW2jqJNspNd8HZrneg/le/u/dNYOz9/uCIJyeMGaX KNHw== X-Forwarded-Encrypted: i=1; AFNElJ9LWFA5T/J6EWXK+wtlbfzabKDZut5mpihxIx3CdbVcJiGc9nLOJFrdDgo2XWESQ5ouaANTDlg=@vger.kernel.org X-Gm-Message-State: AOJu0YzxucchejUaG0H0wBt835qJeMVcNHcZe0yYollIsms44hlC+pTP dPN/5A4j2vsrhWXBU5N54kFLNrM66apnhFo+DIijeHHmmoqAhU/8TB// X-Gm-Gg: Acq92OGvB/i8skL0N/KCaLCHJTW3V7yCnN44Ox5Qepd5UozNsTppogXshdlSe0AIb6i 7cbeZhSA+WLK/VDA3xyIS+68nI+Yd/k6YutGl9IGGxjLJTazro8Hyz4SH+Txq4He931l5fVtRGZ wRKGaPF0GpU5AkBUepmw4DNVK3NOi0IuUTgZkZMhh4W3HMDAj8IHlamBSv2bTY/XH8fHstmDUDp hBvc6lncElnd9Jl8uLc0d+YbZC0/xKT9xcmlNXlMTV0Vxv8UjR/lnj1L/cYeN2lnugliADRNWmN IOPqC74Sx2He+2DXHiRDjv7DWvx66X5LWfDLp0ZybzbUVayD+mgRaq4D2+0hr3j1JFxkVISBiGk OGUXFOhBR4CEnwbmdE5EzJruGUjuWYXaOIzV3X/vLa+YOPYUTiMMsrw4LA6o+tqneo0K1ihk7P2 dYK2rBdcbKStDND2QD1rtkh4MeB0w+4EcPXtCVbjVDWQoUZvExpGbEtcKZLnwHVRO19NKFDrn4w Oih9MaK+nVSaluzAw== X-Received: by 2002:a05:6820:1787:b0:69d:7a88:9cde with SMTP id 006d021491bc7-69edc73e0a1mr3369586eaf.26.1781314269167; Fri, 12 Jun 2026 18:31:09 -0700 (PDT) Received: from localhost ([2a03:2880:10ff:45::]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4426abf2782sm3492674fac.8.2026.06.12.18.31.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jun 2026 18:31:08 -0700 (PDT) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 12 Jun 2026 18:31:06 -0700 Message-Id: Cc: "Song Liu" , "Yonghong Song" , "Jiri Olsa" , "Andrew Lunn" , "David S . Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Simon Horman" , "Willem de Bruijn" , "Kuniyuki Iwashima" , , Subject: Re: [PATCH v2 bpf-next/net 5/5] selftest: bpf: Add test for hwtstamp proxy. From: "Alexei Starovoitov" To: "Kuniyuki Iwashima" , "Alexei Starovoitov" , "Daniel Borkmann" , "Martin KaFai Lau" , "Stanislav Fomichev" , "Andrii Nakryiko" , "John Fastabend" , "Kumar Kartikeya Dwivedi" , "Eduard Zingerman" X-Mailer: aerc References: <20260613010039.1362312-1-kuniyu@google.com> <20260613010039.1362312-6-kuniyu@google.com> In-Reply-To: <20260613010039.1362312-6-kuniyu@google.com> On Fri Jun 12, 2026 at 6:00 PM PDT, Kuniyuki Iwashima wrote: > diff --git a/tools/testing/selftests/bpf/bpf_kfuncs.h b/tools/testing/sel= ftests/bpf/bpf_kfuncs.h > index 7dad01439391..8d119b10ed0d 100644 > --- a/tools/testing/selftests/bpf/bpf_kfuncs.h > +++ b/tools/testing/selftests/bpf/bpf_kfuncs.h > @@ -92,4 +92,14 @@ extern int bpf_set_dentry_xattr(struct dentry *dentry,= const char *name__str, > const struct bpf_dynptr *value_p, int flags) __ksym __weak; > extern int bpf_remove_dentry_xattr(struct dentry *dentry, const char *na= me__str) __ksym __weak; > =20 > +extern int bpf_skb_scrub_tx_tstamp(struct __sk_buff *s) __ksym __weak; > + > +struct bpf_hwtstamp; > +extern int bpf_skb_set_hwtstamp(struct __sk_buff *s, > + struct bpf_hwtstamp *attrs, int attrs__sz) __ksym __weak; > + > +struct bpf_tx_tstamp_cmpl; > +extern int bpf_skb_complete_tx_tstamp(struct __sk_buff *s, > + struct bpf_tx_tstamp_cmpl *attrs, > + int attrs__sz) __ksym __weak; ... > diff --git a/tools/testing/selftests/bpf/progs/proxy_hwtstamp.c b/tools/t= esting/selftests/bpf/progs/proxy_hwtstamp.c > new file mode 100644 > index 000000000000..e13963f2393e > --- /dev/null > +++ b/tools/testing/selftests/bpf/progs/proxy_hwtstamp.c > @@ -0,0 +1,236 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* Copyright 2026 Google LLC */ > + > +#include "vmlinux.h" Please update your pahole. It must be old, since you had the need to add kfuncs defs into bpf_kfuncs.h. pahole was improved couple years ago and all kfuncs now in vmlinux.h automatically. Overall, the set looks good to me, but I would like to see an ack for networking bits from somebody. bpf-next/net was the right subj to use, but this is very late into release cycle, so I prefer to land it to bpf-next/master and send together with main bpf-next PR. Kuba, is is ok with you? thoughts on patchset overall?