From: "Weiming Shi" <bestswngs@gmail.com>
To: "Jakub Kicinski" <kuba@kernel.org>, "Weiming Shi" <bestswngs@gmail.com>
Cc: "Chas Williams" <3chas3@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
<linux-atm-general@lists.sourceforge.net>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Xiang Mei" <xmei5@asu.edu>
Subject: Re: [PATCH v2] atm: fix use-after-free in sigd_put_skb()
Date: Tue, 16 Jun 2026 20:39:57 +0800 [thread overview]
Message-ID: <DJAHB7Q63R2X.1IQUT9806HSE8@gmail.com> (raw)
In-Reply-To: <20260612161051.2d4df09b@kernel.org>
On Sat Jun 13, 2026 at 7:10 AM CST, Jakub Kicinski wrote:
> On Wed, 10 Jun 2026 00:21:08 +0800 Weiming Shi wrote:
>> sigd_put_skb() delivers a signalling message to the daemon socket named
>> by the global @sigd pointer, ending in a call to sk_data_ready(). It
>> reads @sigd with no synchronisation, so it can race with a close of the
>> daemon socket: sigd_close() clears @sigd and the socket is then torn
>> down and freed.
>
> Hm, we intend to only retain the portions of the ATM stack which are
> still used in PPPoATM and ADSL. I don't believe the signaling stuff
> is used there. I will post a patch to delete this code.
Thanks, that makes sense to me.
prev parent reply other threads:[~2026-06-16 12:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 16:21 [PATCH v2] atm: fix use-after-free in sigd_put_skb() Weiming Shi
2026-06-11 16:26 ` Weiming Shi
2026-06-12 23:10 ` Jakub Kicinski
2026-06-16 12:39 ` Weiming Shi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJAHB7Q63R2X.1IQUT9806HSE8@gmail.com \
--to=bestswngs@gmail.com \
--cc=3chas3@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xmei5@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox