From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B84B3644CF for ; Fri, 19 Jun 2026 21:55:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781906122; cv=none; b=QZDs+hgd3VwsLmUXihVulhjblBzES9GZD/fDvC/LLAmMb8Rm1k64q1XlVyl4CFzQb3ToodS5D6QAqru2yd9ZJsKAzylN4krhO6s0VymECh/3sKJDYw6izAbuqL1EXuaCRpzkdqAbLL3OvzMrwQbcpdwDaLeZYflPIHTdF1cyPgE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781906122; c=relaxed/simple; bh=1TBT000VZsjsrh2eGBT6mjiiO1fTUs34DeS+O0xeYrQ=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=jubo+eKIeGte60OGQ0fxhBcfpJURGvCcykFyUG714n1pdqyxvchnWS7atnSh4MP1PHCRtw6KMyCqDpwOwT4MQdme2DFZo5gG2OJ1ZlolW+7u72SVEPh4hufWsYQeEB3UPi/3tm53+RvEycKBRTX8dP3qOyrZ4aFvi9QVAGFewe8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P5qtjfBr; arc=none smtp.client-ip=209.85.210.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P5qtjfBr" Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-7e6cfdc92bfso898702a34.2 for ; Fri, 19 Jun 2026 14:55:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781906120; x=1782510920; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1D3cBmNu4YFH8WjCxOSV1D9t43oN1k/1HHsWttX0H6M=; b=P5qtjfBrJEYGa3WsF0ZfelJ6Urg50+QFj39AUSfTWfUoGuCBRxJsMtGMJZRmet4ODK a066sxrmhNEl71PCuV6g2koK5CQmLxW2KwFs3No9k2LpJi8Eo1SITjwb0I/iSVMDymCL PLToqUI5rpF2lzlLakExkaMXbUNoLQxTice5RMRsU73OIf0IpYU+IXmXOaWY/m0i3SB0 qvrWch4r+0/wNgbHSXDv9koe4DjjF8YaeMJwwEGerXTryRhB6D3Z5WGlPLKbz9hceqPM bj/pMbA2roCYPN0EgM6Gj+xkCrVc8iVBYIN6xfoyj75dzGj/Qh80fjwki9ftaS2wNVsy FrrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781906120; x=1782510920; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1D3cBmNu4YFH8WjCxOSV1D9t43oN1k/1HHsWttX0H6M=; b=gxBjVx6XQe3vYIaaJT4IGnL5Q2BI7IFvK8viXfNH8ND6nW4SNG2xYA9iCfc3itiIwj pGuS/433f/IcrprFRNX5xw2Pf3lyS65MPzTp6cEvXzKXeHaXBiI8yyXg8f+EjhrUGQYa JWAxh+B1eoQNHPIdXU7PLJbZxjGWzwWHNmj6vfc0qqXaPwwS9ehnCmsM3VA4frRSt728 mqNzaiyna/bx3eTuz7AFl0vTxDDZo5BRdmFFkTkt8EC+gxc+Wuww7xazbDWPJUP4R5h2 aMMagerkCvEZpsVcOryIdn/Y3tG+PPJpV20DkrGYBwBpdN4yViATvbWODYcq1mILffP4 hTfw== X-Forwarded-Encrypted: i=1; AFNElJ/tKcWGwjzabZpre948Lp7UuonW7x+I6XDLJAUZ2TU15i14aVy8dXQfKHgeHx14jJbmK1+QHwA=@vger.kernel.org X-Gm-Message-State: AOJu0YxE53M7z/+PWQwCFvIsuAzSKs5xTjUV3tUm8EryyRdNFGVg+maq /MtAbMQu7FDEdDu3v3JIayqjgpXP8DLW69xkXyrB4tHhUOuebfw783twSqGBhQ== X-Gm-Gg: AfdE7cnw3s0CJaX1h303XCZKCwAKnlkiKQNS0+FKxyxmhhpSzM8KCZDl19weyyZRV72 aNBKHtW1rYEjvx56k8UwB0ortWGSJhUFw72R3112mwEj71rVkCsBkrI9bRLaO6SlCoxYx4zfNRX C37NI3lWco01BIlQCV+8SoDvQ0yE6XG6gAT3exYRU33JFcKVEw5oGu6NxGNcfvNNWrVyjsvUwzW baFSCTKj0Zqq/zvFcnnEo5xdILpyHDdyD4G+Bmv/jfUREgvoxO7oE3PFrJtgfcO2kYtlTnmn6VX nCmnN6sT/vrPPbc1OBoQOkssv8QAYtGkfL6F4f0tt//+p7qA/RP2mazmk4lbhEeBz0JVGHAlajd tzQufvZaf5TBID1YJsH7LdGsSvJsDtX0QKSOtZ2E/lfedkV3gkAVvy9hDwfsIA9niXyPPXOj0bJ k4BNwVg2ZtaxcwDNmy/wLQDO8/gFU6YV7L9yMauWk8cRP6kjLeDZ1iP8SiDDOQZuLBd3i3jsuNj Bd2VOY= X-Received: by 2002:a05:6830:620b:b0:7e6:cec2:a4a5 with SMTP id 46e09a7af769-7e92d8aec54mr4035312a34.20.1781906120073; Fri, 19 Jun 2026 14:55:20 -0700 (PDT) Received: from localhost ([2a03:2880:10ff:47::]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e94424ca09sm293111a34.16.2026.06.19.14.55.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jun 2026 14:55:19 -0700 (PDT) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 19 Jun 2026 14:55:18 -0700 Message-Id: To: "John Fastabend" , "Sechang Lim" Cc: "Jiayuan Chen" , "Jakub Sitnicki" , "Alexei Starovoitov" , "Daniel Borkmann" , "Eric Dumazet" , "Kuniyuki Iwashima" , "Paolo Abeni" , "Willem de Bruijn" , "David S . Miller" , "Jakub Kicinski" , "Simon Horman" , , , Subject: Re: [PATCH bpf] bpf, sockmap: fix lock inversion between stab->lock and sk_callback_lock From: "Alexei Starovoitov" X-Mailer: aerc References: <20260616091153.2966617-1-rhkrqnwk98@gmail.com> <575a878e-6d37-4337-a821-4883d3dd3a63@linux.dev> In-Reply-To: On Wed Jun 17, 2026 at 9:59 AM PDT, John Fastabend wrote: > > The bot also thinks it found another locking issue. I'm not sure > supporting 'tc' is really needed here. sockmap is much more easy > to reason about from socket layer. What about just blocking sockmap > manipulations from these prog types. > > My current thinking on sockmap at the moment is its has sprawled > across so many layers the locking is overly tricky to reason about. > > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c > index d9bdc3b32c05..5e08d3e03453 100644 > --- a/kernel/bpf/verifier.c > +++ b/kernel/bpf/verifier.c > @@ -8567,11 +8567,7 @@ static bool may_update_sockmap(struct bpf_verifier= _env *env, int func_id) > return true; > break; > case BPF_PROG_TYPE_SOCKET_FILTER: > - case BPF_PROG_TYPE_SCHED_CLS: > - case BPF_PROG_TYPE_SCHED_ACT: > - case BPF_PROG_TYPE_XDP: > case BPF_PROG_TYPE_SK_REUSEPORT: > - case BPF_PROG_TYPE_FLOW_DISSECTOR: > case BPF_PROG_TYPE_SK_LOOKUP: > return true; +1. Let's disable.