From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B70B3AB498 for ; Mon, 3 Aug 2026 08:03:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785744182; cv=none; b=TNJM/khe2AhkfKiKsI7LMmGGdJeL0Nf6pmG6i7OhjWjPIylu0X8piUKU6knZtbuJyhTJ2Jp8G6O2WnMYsXJzKPvYzjtZRca+EbLKYzLSvtO+7x6RIUQsjHqmBHJJDOxcJ73ReI2r6ZjCfTY1mTBAJIenRtuafr1tYe8YXFVF0Gk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785744182; c=relaxed/simple; bh=e0BG+pJE+hg9ad13uORYq52K3Lc469BDks34Ro3IRB0=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=h/aQfqnIWdAeswZ55sfp1prKECpk4FULvkm2aRGb2YmpzubHGNeaIAaeXoYAl5/aODypfXyxMQygYm6uGgS//8roooUPYrdd4vDDjVntUHSyNN8adQnh/mF35Uo41Gbw9G1+T5v8vj+ufawK6ZQ84DHhubQfcmQo1S3elAciP+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=23uwmkxG; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="23uwmkxG" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4956242332dso15762355e9.2 for ; Mon, 03 Aug 2026 01:03:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1785744179; x=1786348979; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=vc9B/yx3888mzr7CTqfaAlTdFjWQOBw2cbII84IGS9Q=; b=23uwmkxGxJpjT5yBvDTde5vnWx9cQe7DWTKVI5G7Kh6Tdi7HbCuP87l3Ybcjrcn6hx bRaYMP/7OkbbxHTz5aHOxMGJcy+egIyfwZDYsTmrVN70Jsw0gDwCgf7HBhRKx+j17c6X Rmnb0kFFtGn6nBTnIvi8v9JLjKVAl8AK2sCvDS0xD4pKX/vttg5wkzeuO3n2aSNiOXF/ c2TRoXCSE6IVh+le1Yk05DYrdHNqe4GtP1gXuNZev700kfaatLgrGPvtOJGeUnLyVX97 2rDs2+6f2X5pY5jAz2bHuWl1Flqt+k+YvrxHpxHZRIavosdp8Lu3ozkW7HPX4UulPi/+ LPYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785744179; x=1786348979; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vc9B/yx3888mzr7CTqfaAlTdFjWQOBw2cbII84IGS9Q=; b=jp5o91RqREOVCfnweVuN7JtRmRikmc9Gp91zLD7I3nzOg2Mr+T3kALEpvX6Kkr/krr c6paC/E7DfHtVpn346wOcnI75W73luiEQAYT8VGB++s6wIct0MC8buAjyPHyTmwCDKdE J5+GLCB8u45pR+FanHjtnHqzafoDR7b6sRno5xNX1SqrGabU7JQgg+mJu1lBUf8gsg34 ue5GjSYyS6DoeXAt5VIhl21uAOM27KaZH/LN46fRY7jj5yrgCt/Pg6WKMit21/8gyxCU GdlhDeD8AlJk0sbQRQljGmE27EIFovABDiHU1SaS1bnAMGL44rsAslNjXcZpz/mh0xTn 8/wQ== X-Forwarded-Encrypted: i=1; AHgh+RpRN6XoYIMSy/ej99rGUXbXFrUmvNtiub8nqXQ1sT6/r3mMDHZRmYumZO49/M6dbWfl/PN4FpI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7QX4fbTan/PleMwDHrE4ZxT+1mKBFcJocXQz8X/BS8Y+ecbRb OPD+mvdndCh8LdNRHw/apI6wuv7Qj/EI99980urkqcPn8uSJ0uKgVbDi2fAwXYeUhHQ= X-Gm-Gg: AR+sD12z/qyU1LcQ/C6/CqA9qamHBA5uyohmlF+TUxgVIH4/RfqS1v8Z4NKffny2sEm c5YwcE2mlblQmKlYMBcCU/pL0bJqN3E9hLQ5JGxH2OSyjdux/CXPfbNo99HywJB3lqCZ9nVlP6s MUYxuCMi42AiGz2cXahfhcdw1WyarS3r28etup6BdwXN6g8+3LMP7JS4nXwMjL2Wj1B8BgZ5bSi 6gf71zzubIC3ZVSJaiZzHh7ABJFXNvGsJ1I2Q50Gg+9WXmcN7z9pJASQ3jAaR3SzuRRnt0TUfnf LSK8P15xNfqELtiND0hGhX4RoPbcWP9K1Qa90XtyQlVdka1xzl5c2vHM3b/n1rIICyGxQJbl6IU UgxG23han9Y/0/pDAwTvcSUtAL1OmtyEG5iD96ZLFTU/uF9ztzbCcn41y7rnGL2hC1AIbhqfdst WTjfx89BrzDdFfTRG40bTU+hfzYfKHkL/YLxa8QCdw34I4P860xqKfVMhgb895coYHxA== X-Received: by 2002:a05:600c:840f:b0:493:c42e:5be0 with SMTP id 5b1f17b1804b1-4980c60705amr179044905e9.0.1785744178527; Mon, 03 Aug 2026 01:02:58 -0700 (PDT) Received: from localhost ([213.208.155.167]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49808691014sm211742535e9.11.2026.08.03.01.02.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 01:02:58 -0700 (PDT) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 03 Aug 2026 10:02:45 +0200 Message-Id: From: "Luca Weiss" To: "Jorijn van der Graaf" , "David Heidelberg" , "Krzysztof Kozlowski" Cc: "Andrew Lunn" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Rob Herring" , "Conor Dooley" , "Bjorn Andersson" , "Konrad Dybcio" , "Luca Weiss" , , , , , Subject: Re: [PATCH v3 5/5] arm64: dts: qcom: milos-fairphone-fp6: Add NFC X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260726222405.153008-1-jorijnvdgraaf@catcrafts.net> <20260726222405.153008-6-jorijnvdgraaf@catcrafts.net> In-Reply-To: <20260726222405.153008-6-jorijnvdgraaf@catcrafts.net> Hi Jorijn, On Mon Jul 27, 2026 at 12:24 AM CEST, Jorijn van der Graaf wrote: > Add the Samsung S3NRN4V NCI NFC controller on i2c1. Its XI clock is > provided by the RF_CLK2 PMIC buffer and gated through the controller's > CLK_REQ line on tlmm GPIO6. PVDD is fed from PM7550 LDO20, the rail the > downstream driver switches for this chip. > > The enable line is routed to the chip's power-down input, which is > asserted high to turn the chip off (the downstream driver treats VEN as > active-low on this design) -- hence GPIO_ACTIVE_HIGH, unlike the > exynos5433-tm2 wiring of the same driver. The pin is pulled up so the > chip stays off while the line is not driven. > > Assisted-by: Claude:claude-opus-4-8 > Assisted-by: Claude:claude-fable-5 > Signed-off-by: Jorijn van der Graaf > --- > .../boot/dts/qcom/milos-fairphone-fp6.dts | 49 ++++++++++++++++++- > 1 file changed, 47 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm6= 4/boot/dts/qcom/milos-fairphone-fp6.dts > index ebdca0e2d2f3..a1b86e4092fe 100644 > --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts > +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts > @@ -601,9 +601,29 @@ &gcc { > }; > =20 > &i2c1 { > - /* Samsung NFC @ 0x27 */ > - > status =3D "okay"; > + > + /* > + * Samsung S3NRN4V NFC controller. XI is driven by the RF_CLK2 PMIC > + * buffer; the chip has no oscillator of its own and gates the clock > + * via its CLK_REQ line, so the clock must be voted on in response > + * to it. > + */ I don't think this comment deserves to be in the dtsi, having these details in the commit message is enough imo. > + nfc@27 { > + compatible =3D "samsung,s3nrn4v"; > + reg =3D <0x27>; > + > + clk-req-gpios =3D <&tlmm 6 GPIO_ACTIVE_HIGH>; > + clocks =3D <&rpmhcc RPMH_RF_CLK2>; I'm not sure about these, the NFC chip is connected to PMK7635 CLK7_LN which is part of the LNBB clocks, CLK1_RF - CLK5_RF are the RF clks, CLK6_LN - CLK9_LN are the LNBB clocks so shouldn't this be <&rpmhcc RPMH_LN_BB_CLK2>? But I honestly couldn't find anything in the downstream dts so maybe either these clocks are always on anyways or something else is going on there? Regards Luca > + en-gpios =3D <&tlmm 56 GPIO_ACTIVE_HIGH>; > + interrupt-parent =3D <&tlmm>; > + interrupts =3D <31 IRQ_TYPE_EDGE_RISING>; > + pinctrl-0 =3D <&nfc_clk_req_default>, <&nfc_irq_default>, > + <&nfc_pd_default>; > + pinctrl-names =3D "default"; > + pvdd-supply =3D <&vreg_l20b>; > + wake-gpios =3D <&tlmm 7 GPIO_ACTIVE_HIGH>; > + }; > }; > =20 > &i2c3 { > @@ -825,6 +845,31 @@ &tlmm { > <13 1>, /* NC */ > <63 2>; /* WLAN UART */ > =20 > + nfc_clk_req_default: nfc-clk-req-default-state { > + pins =3D "gpio6"; > + function =3D "gpio"; > + drive-strength =3D <2>; > + bias-disable; > + }; > + > + nfc_irq_default: nfc-irq-default-state { > + pins =3D "gpio31"; > + function =3D "gpio"; > + drive-strength =3D <2>; > + bias-disable; > + }; > + > + /* > + * Pulled up so the NFC chip stays powered down while the line is > + * not driven (it is the chip's active-high power-down input). > + */ > + nfc_pd_default: nfc-pd-default-state { > + pins =3D "gpio56"; > + function =3D "gpio"; > + drive-strength =3D <2>; > + bias-pull-up; > + }; > + > sdc2_card_det_n: sdc2-card-det-state { > pins =3D "gpio65"; > function =3D "gpio";