From: "Théo Lebrun" <theo.lebrun@bootlin.com>
To: "Nicolai Buchwitz" <nb@tipi-net.de>,
"Vineeth Karumanchi" <vineeth.karumanchi@amd.com>
Cc: <conor.dooley@microchip.com>, <andrew+netdev@lunn.ch>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <git@amd.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: macb: fix NULL pointer dereference on unbind with fixed-link
Date: Thu, 03 Sep 2026 10:28:03 +0200 [thread overview]
Message-ID: <DL5JFDSQECL6.1CH7S2Z56QSVA@bootlin.com> (raw)
In-Reply-To: <febc4b0932422a2e67f64599dd520e0d@tipi-net.de>
Hi Nicolai,
On Thu Sep 3, 2026 at 9:23 AM CEST, Nicolai Buchwitz wrote:
> On 2.9.2026 12:28, Vineeth Karumanchi wrote:
>> @@ -5971,8 +5971,10 @@ static int macb_probe(struct platform_device
>> *pdev)
>> macb_free_tieoff(bp);
>>
>> err_out_unregister_mdio:
>> - mdiobus_unregister(bp->mii_bus);
>> - mdiobus_free(bp->mii_bus);
>> + if (bp->mii_bus) {
>> + mdiobus_unregister(bp->mii_bus);
>> + mdiobus_free(bp->mii_bus);
>> + }
>>
>> err_out_phy_exit:
>> phy_exit(bp->phy);
>> @@ -6001,8 +6003,10 @@ static void macb_remove(struct platform_device
>> *pdev)
>> unregister_netdev(netdev);
>> macb_free_tieoff(bp);
>> phy_exit(bp->phy);
>> - mdiobus_unregister(bp->mii_bus);
>> - mdiobus_free(bp->mii_bus);
>> + if (bp->mii_bus) {
>> + mdiobus_unregister(bp->mii_bus);
>> + mdiobus_free(bp->mii_bus);
>> + }
>
> nit: replica of the code from above, but also not really worth a helper?
Agreed that the helper is overblown!
Thanks,
--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-09-03 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 10:28 [PATCH net] net: macb: fix NULL pointer dereference on unbind with fixed-link Vineeth Karumanchi
2026-09-03 2:17 ` Xuanqiang Luo
2026-09-03 7:23 ` Nicolai Buchwitz
2026-09-03 8:28 ` Théo Lebrun [this message]
2026-09-03 8:27 ` Théo Lebrun
2026-09-03 9:37 ` Karumanchi, Vineeth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DL5JFDSQECL6.1CH7S2Z56QSVA@bootlin.com \
--to=theo.lebrun@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor.dooley@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=git@amd.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vineeth.karumanchi@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox