From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f43.google.com (mail-pz2-f43.google.com [74.125.228.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6B684EDCB3 for ; Thu, 17 Sep 2026 20:11:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789675899; cv=none; b=TyHOXw9vzwkAbkl1D+q5ppHgdpFLElQ3F3Xtb5j1Mo97EnSEA1KkDAlfgIzWhmty0D++bDC4rzOifULmnustFfCg59AX1MPOcxf6w5bq5PapMicDxwWCb76kQgk47dVxoln9oYFL3+XvBbtpoRBtu9BssX9WnLqPJwWL1w6GI2U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789675899; c=relaxed/simple; bh=Pld+KJDf/y0brTSHAZfyNj7LwB26z/vcvvMjg82D16g=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=MFLnYUiFWXG38k27EEyF6VwQ+77fkUbb1VubiZk+8KktqO+Upu5vm8DTljcSnlBIcGtnTCtfPMaYtep9uly0V2Elo6X9K7Io2S+MUn+rOsjtZQIrg14jczBD+6Rhqio1Vowx5FMQlnnHB50Qgzku7k25GUU0zUQyPV2uPHjIwLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jEG1HNV1; arc=none smtp.client-ip=74.125.228.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jEG1HNV1" Received: by mail-pz2-f43.google.com with SMTP id d2e1a72fcca58-85469a34907so75852b3a.1 for ; Thu, 17 Sep 2026 13:11:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789675884; x=1790280684; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=Pld+KJDf/y0brTSHAZfyNj7LwB26z/vcvvMjg82D16g=; b=jEG1HNV1nB356xIIlFyTqdaGPUUh9EjM/3PMbUs+3AGI4ehoP6+sJVH1PhlKRJdi74 49iLVhT9tC9NObKt7CYqbEQamlyNxL8drgZcjYZ9wTLMuI4t48nW91cDfveXf0Si7vCw 54dSWTEmPbs9HqyhwNdcIeab67Tty0F+QyFDkFaySQpj76fSQNllBZtFFvlb1jacOCR2 FmpL9hmFxdFK867OkjHeAXKI83GK8UB4CV1xuosFIQTGXxVsJUsjkAlXWhAILWlyh4HL lpFK8QRjRmw0sPKGRoO7Aa3cih6io/pYDi7ISzk1TEp/o6Wckao1szsQ3Um6dWzlqWkz 9vEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789675884; x=1790280684; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Pld+KJDf/y0brTSHAZfyNj7LwB26z/vcvvMjg82D16g=; b=pxOOW3B9caK/dPNT+OvWtTwMQJWqzwgu3WqPeqhFWIVVwwUDYqkdILOQTs/9LoV5L6 xywyjBnA7SdToGdt/CDDs2k6XZRAgNafDtt0B+7hBK3AQ3XKP/Fz3GOsoYrAvJfhtCDE L8ek1OtJGnbr8D5fdvWMvGPG1t3Vnq4lKDiCzkRFuQjjCPT+DjLFQkJMWnfx4Tat37YI 9I7hT/JVpbvOa7wwKScUmpkixOqPU6z4HgLIzcqjpgRJPuo9SO9HKUSaUa3Ej6GrNjv1 D7nejjU1XKAb7c1kWqotTdd/RV+cpyfjGnpXUHiUT4Fdnv339tk6kslm7HKcH+fjB2WZ ddWw== X-Forwarded-Encrypted: i=1; AKwUvBxNeyCPC45FDh1wHySdR/gf8Pjq+/xvAQI+LkCvlYmHbgUfINaQObrSkI692JFmF63IaorKSAo=@vger.kernel.org X-Gm-Message-State: AFuF++mnUKxXIz5vnu2Z43iUMMMelfOESpRDBTFeAhNye990/PQHdynm W97aymNtOTSCP0HspjmeMmazecwhqTCD/k+5DWDPiuxqz0YMLMFnxUhr X-Gm-Gg: AYBFou0ujwDB/d/Mw4tbhcqnYgeVtH8jl8WqkxDP1kPpdz1PYJS41IPJZDCDy4a42Mt oedJr7bs6lrCvHaY7UNGmrbuFB3z3QELEahxSWuTLaTJ09Gf7cM1c9sYkSEkOBVehqBrmdhjepW dyr8Aw2NgkfHIPZUlZn9Y9jJ1PX+cDi7tL3vgfdcTs+17r8a5iWAJ01rus3PQg82lnCJjqynDPf siwaE70CxUKa5BFtXg9pEkvU9g2SQkoFAnOxsj545P7Vv0oWcfMVIgfv+1j3s6NSU/IHGCea8TE /yQ6nQs7s3xwMlZHUip0kKgj4yHCdz3bzELJemihlmz6uxTQluZyl7xoxTVbk2sl/6mLsWm06d2 xfD8DuR8HGeY2b01SRrYMJJbVnihpVDCbHovNIQzac74IZDQscWCGnBu+gFHydHsE8W8klLhmlH BOmvBZ8xa2BETeYJ2zBdmjmJ4u4zAay0Vsxr/Mj4V8CiTpqw9244RvdJZAIfHSn5Eeww26YgvuT jv8bkRaX5ER/E1WQGQYT4+aRdg= X-Received: by 2002:a05:6a20:cfa2:b0:3dd:5831:ef58 with SMTP id adf61e73a8af0-3dd8c456190mr204908637.15.1789675883461; Thu, 17 Sep 2026 13:11:23 -0700 (PDT) Received: from localhost ([13.93.150.60]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-14395d13ee7sm16211287c88.8.2026.09.17.13.11.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Sep 2026 13:11:22 -0700 (PDT) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 17 Sep 2026 20:11:18 +0000 Message-Id: Cc: "David Ahern" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Simon Horman" , "Randy Dunlap" , , "Arun Ajith S" , "Roopa Prabhu" , "Jaehee Park" , "Jonathan Corbet" , "Shuah Khan" , "Shuah Khan" , , , , "Alexander Aring" , , Subject: Re: [PATCH net-next v2 1/2] ipv6: update NUD_FAILED neighbors from NA messages From: "Lawrence Lee" To: "Ido Schimmel" X-Mailer: aerc 0.17.0 References: <6596966f734f3d416bfa83722f7a595149bcc3f8.1789448374.git.lfqlee314@gmail.com> <20260916120202.GA935660@shredder> <20260917143750.GA1332286@shredder> In-Reply-To: <20260917143750.GA1332286@shredder> On Thu Sep 17, 2026 at 2:37 PM UTC, Ido Schimmel wrote: > On Wed, Sep 16, 2026 at 05:43:11PM +0000, Lawrence Lee wrote: > > I added the lowpan changes after my local Sashiko review run=20 > > identified an issue where a FAILED neighbor can retain an outdated=20 > > private short address if it's moved to STALE by a non-override NA.=20 > > Happy to drop all lowpan-related changes or update comments/commit=20 > > message to reflect the changes, please let me know your preference. > > And if the entry is INCOMPLETE and we get a non-override NA? > lowpan_ndisc_update() will ignore it. It's a pre-existing issue and > there is a TODO comment about this: > > "/* react on overrides only. TODO check if this is really right. */" > > You can mention that it's a pre-existing issue under the '---'. That > way, hopefully, Sashiko will not flag it and it won't clutter the git > log. > > > This was added in response to another Sashiko local review finding. =20 > > Let's say we have some FAILED neighbor T with NTF_ROUTER set. If we=20 > > get an NA from source address S with target address T and with the=20 > > Router bit clear, existing kernel code will cleanup routes with=20 > > gateway S, but IMO we should clean routes with gateway T instead=20 > > since that is the neighbor which was updated by the NA. I can either=20 > > update comments/commit message to reflect this or remove the change=20 > > entirely, please let me know your preference. > > And if the neighbour was in a different state than FAILED? It seems like > another pre-existing issue. I guess that in practice, most of the time, > the source address of the NA is also the target address in the payload. > You can mention this under the '---'. I will remove both of these changes, add comments below the '---' as=20 suggested, and resubmit.