From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk2-f40.google.com (mail-qk2-f40.google.com [74.125.230.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49CB25187CD for ; Thu, 1 Oct 2026 15:05:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.232 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790867142; cv=none; b=oSiu6GaMZKYYS3tCsx2L6B9V03ejovG/yHnvi3U+ABqPiBYwWF3XI6ik9Nufj+Fb13NWY5vh0r/cmS8HdzVTDQCzu/5LV8jePuj50k3QxiISR86WBHHdxokhX+FN+nX6aHMF1g8z2iuQHePfyzF1NeitN2LQI2asTGLoV1o99DY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790867142; c=relaxed/simple; bh=maQ6x8roJBA2WylzBMepkb9jK3msk3HJQIscDYF+HeY=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=XvQee5EQHFborng0h4AKSZyFEH8q1fIdv5tEddcnKXFYbDaj8VNCm4zQsdniYMvryqYs4N9oAgzrjmGzn8rF5o1qDOpw/MP6B5VGy521nBW+mB83Pq69kmvsaDTJiESslTTLgoslIeHdJef4nsPuz7YyYKc+Zy5wAZhMDC32HPc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hJlQ8wck; arc=none smtp.client-ip=74.125.230.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hJlQ8wck" Received: by mail-qk2-f40.google.com with SMTP id d75a77b69052e-533945066e8so1346121cf.0 for ; Thu, 01 Oct 2026 08:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790867140; x=1791471940; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=TyPP9Ut3OTHXWr3R5HRJam87Qzk1xhJA+fOjlXaYcmc=; b=hJlQ8wckOAIPUWKWWsjwecAUnMJ134rjtY3eqLZLXVO4FNsbmUTLfXT4ECPGhawE6B +pklE6waAORORV1ovjj6OKi+YDbmtS4tlRllp1PZuuxtnH9kSVKzmZyzOrzQHacilSTa seWTx8JBcO0fZAP3YiA+LK2BreBzhXJZUR0s1bOLlnoZv2bxh3LZC1x7Up7ngyTq1u3+ 7ZRkk19z4wYteOtIWVZmSJhXzMVUGpVLyaEBc1lRjUJDS6kBbIxH27p+EGSSAwL4s+zT w9F5rOxNlCUFJsWp3Go/hGUyX0r3VhYxDS/LSI4DUE1Dy+AM406zxyGMYadMiRaIWexY lecw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790867140; x=1791471940; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TyPP9Ut3OTHXWr3R5HRJam87Qzk1xhJA+fOjlXaYcmc=; b=scN+DdJsIwY1gQot5u1smBwHxEUzFpETKX/G2Y7k/QuZg05Q81rUjdoqhmknqSmVDU ceSxLOT7r69Wd4Zd+m92Ez0KwR8daiPK84vqNWMYt5mJme2OTyja+pZeMFNTKU1LVrGo oyBxjRIyquhylOpQn6SyIVESXTOgSrAmPbgyYYT1WKsz5HJnDZCA5Thi2y2ssoV6+/ux T5li60/Vcg1wgtt60zbsMHRAcBdNGyuxIHiZfcdKTjfVE2IHFmx9baO3gkEZ5oW6VirD igD5pDdDGX65+9COmDlS6SWXbypPyNRR7rDCzx3NgeBe/2mUMNa6Zuh/ntPikzm5ucPi evBA== X-Forwarded-Encrypted: i=1; AKwUvBypslsNAZPsF8mNX92K+gTz8KL2WRYRbFJ5Tzzrk9iLTItMDiOwy3jfISiDT0u9yzth1oprcGY=@vger.kernel.org X-Gm-Message-State: AFuF++myW2ibCPyHC0OWPobY0bas0XP6SLril2mKZcMGy9d5v4b9/Fsl IKGZ/Kkp+HQKeRcjH67fX/J/2EasmnaB+/RN4rxIUCqkS5uRDwCvw3r3 X-Gm-Gg: AYBFou0pTbR4HwckGPuhnqU7QUjbGRaryNjf4sYyMyhBSB7FEyasIwaszqULyaRmXRf Ed0a8xXzTyQSx8YADmOlMIKVDs1DxXq2Yslws3pya9Oag9okNwIgxiQTRZw0zbBUtYez7VCUmZq 1NJvv/FrVCHQZ34S8vJkw1ek9yUdmpD/ggdzRL/TZ62XZLnYvSflo5prYHWqfbn6zmo0yFq3dnR esWvOT62zku9o+zMFgaZgWHWVMv906jlcEJzl9t2cW5t7bVqn5dpi+kzRiXA/p1ZAS9VEkkPi0F jAFWhEq7i1fRif4xe+BbzNFKBpg67DnMx/0r7XaZoz4QrGVLzcxF9/mrE5OExvTsRn9zMXBWY+3 u28zeW5/FEOhRQQ2IQF8CswofDn8+KesrFDxIQTln2DLyeZWaUoMidf5Gms8XtUqzoL2wRi0l34 07M9ocaC8TNJKYnjX66zzOCjMDQb7NtIOJvndFyfdM7cSaAdDpTRhYcsdJ/w== X-Received: by 2002:a05:622a:681b:20b0:533:3d41:b04b with SMTP id d75a77b69052e-5338307d732mr47618591cf.9.1790867138465; Thu, 01 Oct 2026 08:05:38 -0700 (PDT) Received: from localhost ([2620:10d:c091:500::4:fd94]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-53398d122a4sm106011cf.23.2026.10.01.08.05.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Oct 2026 08:05:37 -0700 (PDT) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 01 Oct 2026 11:05:36 -0400 Message-Id: Cc: "Andrew Lunn" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Shuah Khan" , "Willem de Bruijn" , "Simon Horman" , "Jonathan Corbet" , "Shuah Khan" , "Randy Dunlap" , "Kuniyuki Iwashima" , "Willem de Bruijn" , , , , Subject: Re: [PATCH net-next v2 0/4] net: psp: require an established connection for association setup From: "Daniel Zahka" To: , "Daniel Zahka" X-Mailer: aerc 0.21.0-threadmapfix References: <20260930-psp-defeat-v2-0-f266e7447129@gmail.com> <179081213582.31693.9587233196664838966@kernel.org> In-Reply-To: <179081213582.31693.9587233196664838966@kernel.org> On Wed Sep 30, 2026 at 7:48 PM EDT, netdev-bot+sinfo wrote: > Hi! > > This is an automated message. This series looks like a fix, but its > commit messages seem to be missing some information: > > - How the issue was discovered, e.g. hit in production, hit during > development, syzbot report, manual code inspection, LLM or static > analysis tool scan. > > - Whether the issue was actually triggered, or is only theoretical > (e.g. found by code inspection). If it was triggered please include > the symptoms, like the stack trace or error messages. > > Please do not repost the series just to address the above. Instead, > reply to this email with the missing information, so that reviewers > can take it into account. If the series needs another revision for > other reasons, please include the information in the commit messages > then. > > The evaluation is done by an LLM so it may be wrong, if you think > that is the case please reply and explain. This patch could be taken as a fix with: Fixes: 6b46ca260e22 ("net: psp: add socket security association code") The main caveat is that the premise of defeaturing PSP listen sockets relies on two net-next commits: commit 8cc3aef0cb19 ("tcp: Do not allow buggy transitions between ehash and= lhash2.") commit 404381b4f105 ("tcp: Set unhashed_state in inet_twsk_hashdance_schedu= le().") without the above commits, the part of the commit message about defeaturing listen sockets is not true. I considered having just this patch go into net without the promise of defeaturing PSP on listen sockets, but I thought that would be suspect, because a reviewer could point out that we are jumping through hoops to restrict to establishd, but the socket could then be disconnected and transitioned to listen.