From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: "Jakub Kicinski" <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
<daniel@iogearbox.net>, <andrii@kernel.org>, <eddyz87@gmail.com>,
<memxor@gmail.com>, <josef@toxicpanda.com>, <mason@kernel.org>,
<steffen.klassert@secunet.com>, <herbert@gondor.apana.org.au>
Subject: Re: [PATCH net] net: free the policies if a socket's clone fails late
Date: Wed, 21 Oct 2026 03:00:09 +0000 [thread overview]
Message-ID: <DMA6IGX5XTOI.1DVKS3WN0K6NQ@gmail.com> (raw)
In-Reply-To: <20261020192044.7c3a58a1@kernel.org>
On Tue, Oct 20, 2026 at 07:20 PM Jakub Kicinski <kuba@kernel.org> wrote:
> On Sat, 17 Oct 2026 01:39:12 +0000 Alexei Starovoitov wrote:
>> - if (bpf_sk_storage_clone(sk, newsk))
>> + if (bpf_sk_storage_clone(sk, newsk)) {
>> + xfrm_sk_free_policy(newsk);
>> goto free;
>> + }
>
> why not add a new jump target and add the unwind at the end
> of the function?
Don't care. Fix it yourself then.
prev parent reply other threads:[~2026-10-21 3:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-17 1:39 [PATCH net] net: free the policies if a socket's clone fails late Alexei Starovoitov
2026-10-17 1:44 ` netdev-bot+sinfo
2026-10-17 4:04 ` kuniyu
2026-10-18 2:15 ` netdev-bot+sashiko
2026-10-18 15:31 ` Alexei Starovoitov
2026-10-21 2:20 ` Jakub Kicinski
2026-10-21 3:00 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMA6IGX5XTOI.1DVKS3WN0K6NQ@gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=josef@toxicpanda.com \
--cc=kuba@kernel.org \
--cc=mason@kernel.org \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox