Re: [PATCH net] tg3: Invert restart quirk logic to restrict SNP power-down bypass

["Noam D. Eliyahu" <noam.d.eliyahu@gmail.com>]

On Tue Oct 27, 2026 at 12:15 AM IST,  wrote:
> Hi!
>
> This is an automated message. This series looks like a fix, but its
> commit messages seem to be missing some information:
>
>  - How the issue was discovered, e.g. hit in production, hit during
>    development, syzbot report, manual code inspection, LLM or static
>    analysis tool scan.
It's mentioned in the link to the mail discussion earlier, I had
discovered it on my own Dell PowerEdge T440 in production it caused a
reboot hang 100pc of the time due to the known AER issue that my model
wasn't listed in it's growing quirk table
>
>  - Whether the issue was actually triggered, or is only theoretical
>    (e.g. found by code inspection). If it was triggered please include
>    the symptoms, like the stack trace or error messages.
Yes it was triggered the AER logs are identical to those in 2ca1c94ce0b6
Fatal AER event regarding ACPI _PTS and the main symptom is that iDRAC
regards this as fatal and hangs to restart until manually interrupted
>
>  - What hardware the change was tested on. For driver fixes please
>    mention the device (and if relevant firmware version) used for
>    testing, or say that the change was not tested on real hardware.
This change was tested on said Dell PowerEdge T440 which shares the same
Dell Firmware as the R-series and has the same physical NIC mentioned in
all other relevant commits (BCM5720)
>
> Please do not repost the series just to address the above. Instead,
> reply to this email with the missing information, so that reviewers
> can take it into account. If the series needs another revision for
> other reasons, please include the information in the commit messages
> then.
>
> The evaluation is done by an LLM so it may be wrong, if you think
> that is the case please reply and explain.