From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: "Eric Dumazet" <edumazet@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>
Cc: "Willem de Bruijn" <willemb@google.com>,
"Simon Horman" <horms@kernel.org>, <netdev@vger.kernel.org>,
<bpf@vger.kernel.org>,
"David Laight" <david.laight.linux@gmail.com>,
"Willem de Bruijn" <willemdebruijn.kernel@gmail.com>
Subject: Re: [PATCH v2 net] udp: restore hlist_nulls for primary and secondary hash tables
Date: Fri, 30 Oct 2026 16:21:00 +0000 [thread overview]
Message-ID: <DMIB6JXDLTPX.15EVLOCXRDOOO@gmail.com> (raw)
In-Reply-To: <20261030122045.3035709-1-edumazet@kernel.org>
On Fri, Oct 30, 2026 at 05:20 AM Eric Dumazet <edumazet@kernel.org> wrote:
> @@ -3431,12 +3477,12 @@ static struct sock *bpf_iter_udp_batch(struct seq_file *seq)
> for (; state->bucket <= udptable->mask; state->bucket++) {
> struct udp_hslot *hslot2 = &udptable->hash2[state->bucket].hslot;
>
> - if (hlist_empty(&hslot2->head))
> + if (hlist_nulls_empty(&hslot2->head))
> goto next_bucket;
>
> spin_lock_bh(&hslot2->lock);
> - sk = hlist_entry_safe(hslot2->head.first, struct sock,
> - __sk_common.skc_portaddr_node);
> + sk = hlist_nulls_entry_safe(hslot2->head.first, struct sock,
> + __sk_common.skc_portaddr_node);
For bpf bits:
Acked-by: Alexei Starovoitov <ast@kernel.org>
prev parent reply other threads:[~2026-10-30 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 12:20 [PATCH v2 net] udp: restore hlist_nulls for primary and secondary hash tables Eric Dumazet
2026-10-30 12:24 ` netdev-bot+sinfo
2026-10-30 16:21 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMIB6JXDLTPX.15EVLOCXRDOOO@gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=david.laight.linux@gmail.com \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox