Netdev List
 help / color / mirror / Atom feed
From: "Jens Emil Schulz Østergaard" <jensemil.schulzostergaard@microchip.com>
To: <netdev-bot+sashiko@kernel.org>,
	<jensemil.schulzostergaard@microchip.com>
Cc: <UNGLinuxDriver@microchip.com>, <andrew@lunn.ch>,
	<olteanv@gmail.com>, <davem@davemloft.net>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <horms@kernel.org>, <robh@kernel.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<woojung.huh@microchip.com>, <linux@armlinux.org.uk>,
	<Steen.Hegelund@microchip.com>, <daniel.machon@microchip.com>,
	<geert+renesas@glider.be>, <magnus.damm@gmail.com>,
	<edumazet@kernel.org>, <richardcochran@gmail.com>,
	<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH net-next v17 1/4] net: dsa: add tag driver for LAN9645X
Date: Mon, 16 Nov 2026 10:34:30 +0100	[thread overview]
Message-ID: <DMWJ6KL2KBTD.3IW15M9FBCA4H@microchip.com> (raw)
In-Reply-To: <179476095473.2199510.3725439999561374295@kernel.org>

On Sun Nov 15, 2026 at 5:42 PM CET, netdev-bot+sashiko wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider.
>
> Critical: 0 · High: 0 · Medium: 1 · Low: 0
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [Medium] The receive and transmit halves of the LAN9645x tagger
>   disagree about which bridge VLAN protocol they support, and nothing…
>
> --
>
> net: dsa: add tag driver for LAN9645X
>
> This adds a DSA tag driver for the Microchip LAN9645x switch, which uses a
> front port as an NPI CPU port. Extraction uses a 16 byte long prefix plus a
> 28 byte IFH, and injection uses the IFH only. On receive, VLAN tags popped by
> the hardware are restored as hwaccel tags; on transmit, VLAN tags are moved
> into the IFH.
>
>> diff --git a/net/dsa/tag_lan9645x.c b/net/dsa/tag_lan9645x.c
>> new file mode 100644
>> index 0000000000000..95caf4e0cc663
>> --- /dev/null
>> +++ b/net/dsa/tag_lan9645x.c
>> @@ -0,0 +1,514 @@
>
> [ ... ]
>
>> +static struct sk_buff *lan9645x_xmit_get_vlan_info(struct sk_buff *skb,
>> +						   struct net_device *br,
>> +						   u32 *vlan_tci,
>> +						   u32 *tag_type)
>> +{
>
> [ ... ]
>
>> +	br_vlan_get_proto(br, &proto);
>> +
>> +	*vlan_tci = 0;
>> +	if (skb->len >= VLAN_ETH_HLEN) {
>> +		if (unlikely(!pskb_may_pull(skb, VLAN_ETH_HLEN))) {
>> +			kfree_skb(skb);
>> +			return NULL;
>> +		}
>> +
>> +		hdr = skb_vlan_eth_hdr(skb);
>> +		if (ntohs(hdr->h_vlan_proto) == proto &&
>> +		    ntohs(hdr->h_vlan_TCI) & VLAN_VID_MASK) {
>> +			vlan_remove_tag(skb, &tci);
>> +			*vlan_tci = tci;
>> +		}
>> +	}
>> +
>> +	*tag_type = (proto != ETH_P_8021Q) ? LAN9645X_IFH_TAG_TYPE_S :
>> +					     LAN9645X_IFH_TAG_TYPE_C;
>> +
>> +	return skb;
>> +}
>
> [ ... ]
>
>> +static struct sk_buff *lan9645x_rcv(struct sk_buff *skb,
>> +				    struct net_device *ndev)
>> +{
>
> [ ... ]
>
>> +	if (ifh_gap_len) {
>> +		/* The tag is restored as a C-tag, not as the TAG_TYPE the IFH
>> +		 * reports. The classifier recognizes both TPIDs as VLAN tags,
>> +		 * so an S-tag has already been used for classification by the
>> +		 * time we get here. Restoring it as 802.1AD would make the
>> +		 * bridge push it back into the payload and reclassify the frame
>> +		 * to the port pvid, on a different VID than the one the
>> +		 * hardware forwarded it on.
>> +		 */
>> +		__vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q), vlan_tci);
>> +	}
>
> [Severity: Medium]
> Do the transmit and receive paths agree on which bridge vlan_protocol is
> supported?
>
> The commit message says:
>
>   This assumes a bridge vlan_protocol of 802.1Q, which is the only
>   protocol the driver offloads.
>
> lan9645x_xmit_get_vlan_info() does three things:
>
> - It reads the bridge protocol with br_vlan_get_proto().
> - It strips a payload tag whose TPID matches that protocol, and the protocol
>   can be 0x88a8.
> - It sets LAN9645X_IFH_TAG_TYPE_S when the protocol is not ETH_P_8021Q.
>
> So the transmit path looks written for 802.1ad bridges. lan9645x_rcv(), on
> the other hand, always restores the popped tag as ETH_P_8021Q.
>
> Does anything enforce the 802.1Q-only assumption?
>
> __br_vlan_set_proto() in net/bridge/br_vlan.c sends
> SWITCHDEV_ATTR_ID_BRIDGE_VLAN_PROTOCOL with SWITCHDEV_F_SKIP_EOPNOTSUPP and
> ignores -EOPNOTSUPP:
>
> 	err = switchdev_port_attr_set(br->dev, &attr, extack);
> 	if (err && err != -EOPNOTSUPP)
> 		return err;
>
> Nothing under net/dsa/ handles that attribute. So it looks like
> "ip link set br0 type bridge vlan_protocol 802.1ad" cannot be vetoed, even
> after lan9645x ports have joined the bridge.
>
> Here is what would happen on such a bridge:
>
> - Every popped S-tag reaches the bridge as a 0x8100 hwaccel tag.
> - br_allowed_ingress() sees that skb->vlan_proto != br->vlan_proto.
> - It pushes the tag back into the payload as a C-tag that was never on the
>   wire.
> - It classifies the frame to the port pvid, not the VID the hardware used.
>
> Meanwhile the transmit path treats S-tags as bridge VLAN tags.
>
> At this point in the series the switch driver has no .port_bridge_join and
> does not program VLAN popping. So dp->bridge is NULL and no tags get popped.
> The problem would only become reachable once VLAN-aware bridge offload is
> added.
>
> Would it make sense to use one model in both directions? One option is to
> drop the LAN9645X_IFH_TAG_TYPE_S handling on xmit and reject 802.1ad. The
> other is to handle the TPID the same way on transmit and receive.

This asymmetry is intentional. The driver will not support an 802.1ad
bridge, when VLAN and bridge support lands it will reject that procotol
to the extend possible.

On RX we have to restore as 802.1Q. The classifier recognizes both TPIDs
as VLAN tags on every port, so on an 802.1Q bridge an S-tagged frame is
classified to its S-VID before it is extracted. Following the IFH and
restoring the tag as 802.1AD would make the bridge push it back into the
payload and classify the frame to the port pvid, so it would be
terminated on a different VID than the one the hardware forwards it on.
Restoring it as a C-tag keeps the two consistent.

On TX the tagger does what the bridge asks for. It moves the tag of
the bridge vlan_protocol into the IFH and signals its type, and leaves
any other tag in the payload. The rewriter pushes the port tag with the
TPID IFH.TAG_TYPE reports, so always signalling a C-tag would send the
tags of an 802.1ad bridge out as 802.1Q tags, without making 802.1ad
work.


  reply	other threads:[~2026-11-16  9:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 15:33 [PATCH net-next v17 0/4] net: dsa: add DSA support for the LAN9645x switch chip family Jens Emil Schulz Østergaard
2026-11-11 15:33 ` [PATCH net-next v17 1/4] net: dsa: add tag driver for LAN9645X Jens Emil Schulz Østergaard
2026-11-15 16:42   ` netdev-bot+sashiko
2026-11-16  9:34     ` Jens Emil Schulz Østergaard [this message]
2026-11-11 15:33 ` [PATCH net-next v17 2/4] dt-bindings: net: dsa: add Microchip LAN9645x switch Jens Emil Schulz Østergaard
2026-11-15 16:42   ` netdev-bot+sashiko
2026-11-11 15:33 ` [PATCH net-next v17 3/4] net: dsa: lan9645x: add autogenerated register macros Jens Emil Schulz Østergaard
2026-11-11 15:33 ` [PATCH net-next v17 4/4] net: dsa: lan9645x: add basic dsa driver for LAN9645X Jens Emil Schulz Østergaard
2026-11-15 16:42   ` netdev-bot+sashiko
2026-11-16  9:35     ` Jens Emil Schulz Østergaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMWJ6KL2KBTD.3IW15M9FBCA4H@microchip.com \
    --to=jensemil.schulzostergaard@microchip.com \
    --cc=Steen.Hegelund@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=daniel.machon@microchip.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=horms@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=magnus.damm@gmail.com \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox