From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: "Jamal Hadi Salim" <jhs@mojatatu.com>, <netdev-bot+sashiko@kernel.org>
Cc: <netdev@vger.kernel.org>, <daniel@iogearbox.net>,
<john.fastabend@gmail.com>, <sdf@fomichev.me>,
<martin.lau@linux.dev>, <andrii@kernel.org>, <eddyz87@gmail.com>,
<memxor@gmail.com>, <song@kernel.org>, <yonghong.song@linux.dev>,
<jolsa@kernel.org>, <emil@etsalapatis.com>,
<ihor.solodrai@linux.dev>, <davem@davemloft.net>,
<edumazet@kernel.org>, <kuba@kernel.org>, <pabeni@redhat.com>,
<horms@kernel.org>, <bpf@vger.kernel.org>, <jiri@resnulli.us>,
<victor@mojatatu.com>, <sashiko-bot@kernel.org>
Subject: Re: [PATCH net-next v4 4/4] bpf: drop the stale dst when redirecting to an explicit nexthop
Date: Thu, 19 Nov 2026 22:40:48 +0000 [thread overview]
Message-ID: <DMZJS8O5A4YX.9T2P4DT0DAB7@gmail.com> (raw)
In-Reply-To: <CAM0EoMkppFKECwmjw+E3tWpXEL3=cyg2VYhgpL+StaSiQf+WAQ@mail.gmail.com>
On Thu, Nov 19, 2026 at 12:29 PM Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> This is still under discussion with Alexei - so:
Answering your earlier quesiton:
yes, a route for A is acceptable on a frame that leaves B.
bpf_redirect() and mirred egress do that today.
__bpf_tx_skb() and tcf_mirred_to_dev() set skb->dev and keep the dst.
__dev_queue_xmit() drops the dst when B has IFF_XMIT_DST_RELEASE.
> I will consider this feedback if we have to resend the whole series or
> per Alexei's pov 1 or 2.
imo 2, 3 and 4 can go.
So pls consider adopting my earlier neigh_update_process_arp_queue() diff.
Need to think more about patch 1. It's probably ok on its own.
prev parent reply other threads:[~2026-11-19 22:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 19:01 [PATCH net-next v4 0/4] net: drop the stale dst when steering to another device Jamal Hadi Salim
2026-11-16 19:01 ` [PATCH net-next v4 1/4] net: xfrm: interface: restore dst_orig on every xfrm interface Jamal Hadi Salim
2026-11-19 20:02 ` netdev-bot+sashiko
2026-11-16 19:01 ` [PATCH net-next v4 2/4] net: dst: keep the LWT metadata of a dropped route Jamal Hadi Salim
2026-11-19 20:02 ` netdev-bot+sashiko
2026-11-16 19:01 ` [PATCH net-next v4 3/4] netfilter: nft_fwd_netdev: drop the stale dst when steering to a device Jamal Hadi Salim
2026-11-19 20:02 ` netdev-bot+sashiko
2026-11-16 19:01 ` [PATCH net-next v4 4/4] bpf: drop the stale dst when redirecting to an explicit nexthop Jamal Hadi Salim
2026-11-16 20:46 ` Alexei Starovoitov
2026-11-16 22:06 ` Jamal Hadi Salim
2026-11-17 4:50 ` Alexei Starovoitov
2026-11-17 13:15 ` Jamal Hadi Salim
2026-11-17 14:00 ` Jamal Hadi Salim
2026-11-19 20:02 ` netdev-bot+sashiko
2026-11-19 20:29 ` Jamal Hadi Salim
2026-11-19 22:40 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMZJS8O5A4YX.9T2P4DT0DAB7@gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@kernel.org \
--cc=emil@etsalapatis.com \
--cc=horms@kernel.org \
--cc=ihor.solodrai@linux.dev \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kuba@kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sashiko-bot@kernel.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=victor@mojatatu.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox