* [patch 01/16] __FUNCTION__ string concatenation
@ 2004-09-01 21:02 janitor
0 siblings, 0 replies; 3+ messages in thread
From: janitor @ 2004-09-01 21:02 UTC (permalink / raw)
To: netdev; +Cc: jgarzik, janitor
I've replaced the __FUNCTION__ string concatenation with the
%s placeholder and a printf parameter in
drivers/net/wireless/prism65/islpci_mgt.h, as suggested in the TODO
list.
I don't have the hardware to do a run-time check. It should not pose any
problems though.
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/07/04 22:08:37+02:00 drizzd@aon.at
# __FUNCTION__ string concatenation is deprecated
#
# drivers/net/wireless/prism54/islpci_mgt.h
# 2004/07/03 17:18:20+02:00 drizzd@aon.at +1 -1
# __FUNCTION__ string concatenation is deprecated
#
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
---
linux-2.6.9-rc1-bk7-max/drivers/net/wireless/prism54/islpci_mgt.h | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/net/wireless/prism54/islpci_mgt.h~printk-net_wireless_prism54_islpci_mgt.h drivers/net/wireless/prism54/islpci_mgt.h
--- linux-2.6.9-rc1-bk7/drivers/net/wireless/prism54/islpci_mgt.h~printk-net_wireless_prism54_islpci_mgt.h 2004-09-01 19:34:23.000000000 +0200
+++ linux-2.6.9-rc1-bk7-max/drivers/net/wireless/prism54/islpci_mgt.h 2004-09-01 19:34:23.000000000 +0200
@@ -31,7 +31,7 @@
#define K_DEBUG(f, m, args...) do { if(f & m) printk(KERN_DEBUG args); } while(0)
#define DEBUG(f, args...) K_DEBUG(f, pc_debug, args)
-#define TRACE(devname) K_DEBUG(SHOW_TRACING, VERBOSE, "%s: -> " __FUNCTION__ "()\n", devname)
+#define TRACE(devname) K_DEBUG(SHOW_TRACING, VERBOSE, "%s: -> %s()\n", devname, __FUNCTION__)
extern int pc_debug;
#define init_wds 0 /* help compiler optimize away dead code */
_
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch 01/16] __FUNCTION__ string concatenation
@ 2004-09-02 11:02 Margit Schubert-While
2004-09-02 15:28 ` maximilian attems
0 siblings, 1 reply; 3+ messages in thread
From: Margit Schubert-While @ 2004-09-02 11:02 UTC (permalink / raw)
To: netdev; +Cc: janitor
On Thu, 02 Sep 2004, Maximilian scribeth:
> drivers/net/wireless/prism65/islpci_mgt.h, as suggested
Woo, we got another project ? (prism65)
> I don't have the hardware to do a run-time check.
> It should not pose any problems though.
Oh, I think we can safely say that, especially as TRACE
is nowhere referenced ;-)
(And therefore the patch is unnecessary)
Margit
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 01/16] __FUNCTION__ string concatenation
2004-09-02 11:02 Margit Schubert-While
@ 2004-09-02 15:28 ` maximilian attems
0 siblings, 0 replies; 3+ messages in thread
From: maximilian attems @ 2004-09-02 15:28 UTC (permalink / raw)
To: Margit Schubert-While; +Cc: netdev
On Thu, 02 Sep 2004, Margit Schubert-While wrote:
> On Thu, 02 Sep 2004, Maximilian scribeth:
> > I don't have the hardware to do a run-time check.
> > It should not pose any problems though.
>
> Oh, I think we can safely say that, especially as TRACE
> is nowhere referenced ;-)
> (And therefore the patch is unnecessary)
yup nice hint it was used:
drivers/net/wireless/prism54/islpci_hotplug.c: /* TRACE(DRV_NAME); */
will resent patch that removes both.
--
maks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-09-02 15:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-01 21:02 [patch 01/16] __FUNCTION__ string concatenation janitor
-- strict thread matches above, loose matches on Subject: below --
2004-09-02 11:02 Margit Schubert-While
2004-09-02 15:28 ` maximilian attems
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).