From: Herbert Xu <herbert@gondor.apana.org.au>
To: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Patrick McHardy <kaber@trash.net>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: [PATCH 6/6] [IPV6]: Remove circular dependency on if_inet6.h
Date: Thu, 26 Jul 2007 17:09:40 +0800 [thread overview]
Message-ID: <E1IDzLo-0000AX-00@gondolin.me.apana.org.au> (raw)
In-Reply-To: 20070726090725.GA510@gondor.apana.org.au
[IPV6]: Remove circular dependency on if_inet6.h
net/if_inet6.h includes linux/ipv6.h which also tries to include
net/if_inet6.h. Since the latter only needs it for forward
declarations, we can fix this by adding the declarations.
A number of files are implicitly including net/if_inet6.h through
linux/ipv6.h. They also use net/ipv6.h so this patch includes
net/if_inet6.h there.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---
include/linux/ipv6.h | 5 ++++-
include/net/ipv6.h | 1 +
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/include/linux/ipv6.h b/include/linux/ipv6.h
index 97983dc..4ca60c3 100644
--- a/include/linux/ipv6.h
+++ b/include/linux/ipv6.h
@@ -219,7 +219,6 @@ enum {
#include <linux/tcp.h>
#include <linux/udp.h>
-#include <net/if_inet6.h> /* struct ipv6_mc_socklist */
#include <net/inet_sock.h>
static inline struct ipv6hdr *ipv6_hdr(const struct sk_buff *skb)
@@ -273,6 +272,10 @@ struct tcp6_request_sock {
struct inet6_request_sock tcp6rsk_inet6;
};
+struct ipv6_mc_socklist;
+struct ipv6_ac_socklist;
+struct ipv6_fl_socklist;
+
/**
* struct ipv6_pinfo - ipv6 private area
*
diff --git a/include/net/ipv6.h b/include/net/ipv6.h
index 46b9dce..9059e0e 100644
--- a/include/net/ipv6.h
+++ b/include/net/ipv6.h
@@ -17,6 +17,7 @@
#include <linux/ipv6.h>
#include <linux/hardirq.h>
+#include <net/if_inet6.h>
#include <net/ndisc.h>
#include <net/flow.h>
#include <net/snmp.h>
next prev parent reply other threads:[~2007-07-26 9:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 9:07 [0/6] Allow registration/change name notifications to fail Herbert Xu
2007-07-26 9:09 ` [PATCH 1/6] [NET]: Call uninit if necessary in register_netdevice Herbert Xu
2007-07-30 23:29 ` David Miller
2007-07-26 9:09 ` [PATCH 2/6] [NET]: Take dev_base_lock when moving device name hash list entry Herbert Xu
2007-07-30 23:36 ` David Miller
2007-07-26 9:09 ` [PATCH 3/6] [NET] loopback: Panic if registration fails Herbert Xu
2007-07-30 23:38 ` David Miller
2007-07-26 9:09 ` [PATCH 4/6] [NET]: Allow netdev REGISTER/CHANGENAME events to fail Herbert Xu
2007-07-31 0:03 ` David Miller
2007-07-26 9:09 ` [PATCH 5/6] [IPV4/IPV6]: Fail registration if inet device construction fails Herbert Xu
2007-07-31 0:05 ` David Miller
2007-07-26 9:09 ` Herbert Xu [this message]
2007-07-31 0:06 ` [PATCH 6/6] [IPV6]: Remove circular dependency on if_inet6.h David Miller
2007-07-26 10:37 ` [0/6] Allow registration/change name notifications to fail Stephen Hemminger
2007-07-26 11:03 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1IDzLo-0000AX-00@gondolin.me.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox