From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Subject: Re: BUG: scheduling while atomic: ifconfig/0x00000002/4170 Date: Thu, 06 Sep 2007 20:36:32 +0800 Message-ID: References: <1189080575.28781.65.camel@johannes.berg> Cc: herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org, satyam-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, flo-BCn6idZOOBwdnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, michal.k.k.piotrowski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, ipw3945-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, yi.zhu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, flamingice-R9e9/4HEdknk1uMJSBkQmQ@public.gmane.org To: johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org (Johannes Berg) Return-path: In-Reply-To: <1189080575.28781.65.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Johannes Berg wrote: > > Hah, I suspected as much but didn't have a chance to look yet. I had > plans to replace that sub_if_list with an RCU list and not require the > lock there, but that's far off. Any ideas how to fix this? We can't > reject the master stop so we have to walk the list, I guess we'll have > to audit the other list manipulation places, I think they're all under > RTNL. Yeah I think they're all under RTNL too. So you don't need to take the lock here at all since you should already have the RTNL. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt