From: Al Viro <viro@ftp.linux.org.uk>
To: dhananjay@netxen.com
Cc: jgarzik@pobox.com, netdev@vger.kernel.org
Subject: [RFC] potential bugs in nexten
Date: Sun, 23 Dec 2007 20:01:04 +0000 [thread overview]
Message-ID: <E1J6X0S-0007Sb-AQ@ZenIV.linux.org.uk> (raw)
* what are default: doing in netxen_nic_hw_write_wx()/netxen_nic_hw_read_wx()?
Unlike all other cases they do iomem->iomem copying and AFAICS they are never
actually triggered.
* netxen_nic_flash_print() reads the entire user_info from card *in* *host-endian*,
then uses user_info.serial_number[].
a) do we need to read the rest?
b) more interesting question, don't we need cpu_to_le32() here? After
all, that sucker is an array of char, so we want it in the same order regardless
of the host...
* in netxen_nic_xmit_frame() we do
hw->cmd_desc_head[saved_producer].flags_opcode =
cpu_to_le16(hw->cmd_desc_head[saved_producer].flags_opcode);
hw->cmd_desc_head[saved_producer].num_of_buffers_total_length =
cpu_to_le32(hw->cmd_desc_head[saved_producer].
num_of_buffers_total_length);
Huh? Everything that modifies either of those does so in little-endian already.
This code appeared in commit 6c80b18df3537d1221ab34555c150bccbfd90260 (NetXen:
Port swap feature for multi port cards); what's going on there?
next reply other threads:[~2007-12-23 20:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-23 20:01 Al Viro [this message]
2007-12-25 1:04 ` [RFC] potential bugs in nexten Dhananjay Phadke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1J6X0S-0007Sb-AQ@ZenIV.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=dhananjay@netxen.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox