From: Al Viro <viro@ftp.linux.org.uk>
To: divy@chelsio.com
Cc: jgarzik@pobox.com, netdev@vger.kernel.org
Subject: [RFC] potential bug in cxgb3
Date: Sun, 23 Dec 2007 20:01:04 +0000 [thread overview]
Message-ID: <E1J6X0S-0007Sd-AW@ZenIV.linux.org.uk> (raw)
int t3_seeprom_wp(struct adapter *adapter, int enable)
{
return t3_seeprom_write(adapter, EEPROM_STAT_ADDR, enable ? 0xc : 0);
}
looks fishy, since t3_seeprom_write() takes the last argument in little-endian,
converts to host-endian and feeds it to pci_write_config_dword(). Passing it
a host-endian instead will end up with different values seen by the card on
l-e and b-e hosts. Shouldn't it be s/0xc/cpu_to_le32(0xc) ?
reply other threads:[~2007-12-23 20:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1J6X0S-0007Sd-AW@ZenIV.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=divy@chelsio.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).