From: Jon Loeliger <jdl@jdl.com>
To: avorontsov@ru.mvista.com
Cc: linuxppc-dev@ozlabs.org,
Jason Wessel <jason.wessel@windriver.com>,
Andy Fleming <afleming@freescale.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH RFC] gianfar: Make polling safe with IRQs disabled
Date: Thu, 05 Nov 2009 08:41:06 -0600 [thread overview]
Message-ID: <E1N63WM-0003xK-PN@jdl.com> (raw)
In-Reply-To: <20091105142028.GB17171@oksana.dev.rtsoft.ru>
>
> Hm, then I'd better remove the #ifdef CONFIG_NETPOLL.
>
> Interestingly though, why conn_track does the polling with irqs
> disabled, could be a bug in the conn_track? Because pretty much
> drivers assume that polling is called with IRQs enabled.
>
> If it's easily reproducible, could you replace the printk() with
> WARN_ON(1) and post the backtrace? Or I can try to reproduce the
> issue if you tell me how.
>
> Thanks!
Yeah, I can reproduce it. I'll try and get that for you.
jdl
next prev parent reply other threads:[~2009-11-05 14:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 22:57 [PATCH RFC] gianfar: Make polling safe with IRQs disabled Anton Vorontsov
2009-11-05 14:01 ` Jon Loeliger
2009-11-05 14:20 ` Anton Vorontsov
2009-11-05 14:41 ` Jon Loeliger [this message]
2009-11-05 15:43 ` Jon Loeliger
2009-11-05 16:57 ` [PATCH RFC] gianfar: Do not call skb recycling with disabled IRQs Anton Vorontsov
2009-11-05 17:23 ` Kumar Gopalpet-B05799
2009-11-05 17:34 ` Anton Vorontsov
2009-11-05 17:40 ` Jon Loeliger
2009-11-05 17:53 ` Anton Vorontsov
2009-11-06 20:38 ` Jon Loeliger
2009-11-05 17:53 ` Kumar Gopalpet-B05799
2009-11-08 9:08 ` David Miller
2009-11-09 13:41 ` Anton Vorontsov
2009-11-08 9:05 ` [PATCH RFC] gianfar: Make polling safe with IRQs disabled David Miller
2009-11-09 13:32 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1N63WM-0003xK-PN@jdl.com \
--to=jdl@jdl.com \
--cc=afleming@freescale.com \
--cc=avorontsov@ru.mvista.com \
--cc=davem@davemloft.net \
--cc=jason.wessel@windriver.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).