From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King Subject: [PATCH CFT 02/30] net: fec: iMX6 FEC does not support half-duplex gigabit Date: Fri, 27 Jun 2014 16:19:03 +0100 Message-ID: References: <20140627151542.GL32514@n2100.arm.linux.org.uk> Cc: Fugang Duan To: linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Return-path: Received: from gw-1.arm.linux.org.uk ([78.32.30.217]:45179 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753579AbaF0PTL (ORCPT ); Fri, 27 Jun 2014 11:19:11 -0400 In-Reply-To: <20140627151542.GL32514@n2100.arm.linux.org.uk> Sender: netdev-owner@vger.kernel.org List-ID: The iMX6 gigabit FEC does not support half-duplex gigabit operation. Phys attacked to the FEC may support this, and we currently do nothing to disable this feature. This may result in an invalid configuration. Mask out phy support for gigabit half-duplex operation. Signed-off-by: Russell King --- drivers/net/ethernet/freescale/fec_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 77037fd377b8..a91fe68030e6 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1667,6 +1667,7 @@ static int fec_enet_mii_probe(struct net_device *ndev) /* mask with MAC supported features */ if (id_entry->driver_data & FEC_QUIRK_HAS_GBIT) { phy_dev->supported &= PHY_GBIT_FEATURES; + phy_dev->supported &= ~SUPPORTED_1000baseT_Half; #if !defined(CONFIG_M5272) phy_dev->supported |= SUPPORTED_Pause; #endif -- 1.8.3.1