From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King Subject: [PATCH A 04/12] net: fec: use netif_tx_disable() rather than netif_stop_queue() Date: Tue, 08 Jul 2014 00:22:49 +0100 Message-ID: References: <20140707232148.GG21766@n2100.arm.linux.org.uk> Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org To: "David S. Miller" Return-path: Received: from gw-1.arm.linux.org.uk ([78.32.30.217]:57977 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751077AbaGGXWv (ORCPT ); Mon, 7 Jul 2014 19:22:51 -0400 In-Reply-To: <20140707232148.GG21766@n2100.arm.linux.org.uk> Sender: netdev-owner@vger.kernel.org List-ID: We use netif_stop_queue() in several places where we want to ensure that the start_xmit function is not running. netif_stop_queue() is not sufficient to achieve that - it merely sets a flag to indicate that the transmit queue(s) should not be run. netif_tx_disable() gives this guarantee, since it takes the transmit queue lock while marking the queue stopped. This will wait for the transmit function to complete before returning. Acked-by: Fugang Duan Signed-off-by: Russell King --- drivers/net/ethernet/freescale/fec_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 4e695b742030..cb9ced738607 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -834,7 +834,7 @@ fec_restart(struct net_device *ndev, int duplex) if (netif_running(ndev)) { netif_device_detach(ndev); napi_disable(&fep->napi); - netif_stop_queue(ndev); + netif_tx_disable(ndev); netif_tx_lock_bh(ndev); } @@ -2181,7 +2181,7 @@ fec_enet_close(struct net_device *ndev) /* Don't know what to do yet. */ napi_disable(&fep->napi); fep->opened = 0; - netif_stop_queue(ndev); + netif_tx_disable(ndev); fec_stop(ndev); if (fep->phy_dev) { -- 1.8.3.1