From: Russell King <rmk+kernel@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org
Subject: [PATCH CFT] net: phy: micrel: remove unnecessary duplicate interrupt enable
Date: Tue, 12 Dec 2017 11:02:12 +0000 [thread overview]
Message-ID: <E1eOiKC-0002ne-Mh@rmk-PC.armlinux.org.uk> (raw)
Now that we call phy_resume() before enabling interrupts, the workaround
in micrel is no longer required.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
This depends on the previous "net: phy: fix resume handling" patch, but
is not necessary to be a part of it. Since kszphy_resume() is used for
PHYs which I don't have, I can't test this, so I decided to keep it
separate. Can we get it tested on KSZ8081, KSZ8091 or KSZ9031 PHYs?
drivers/net/phy/micrel.c | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index fdb43dd9b5cd..9e9438caa2b7 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -711,22 +711,9 @@ static int kszphy_suspend(struct phy_device *phydev)
static int kszphy_resume(struct phy_device *phydev)
{
- int ret;
-
genphy_resume(phydev);
- ret = kszphy_config_reset(phydev);
- if (ret)
- return ret;
-
- /* Enable PHY Interrupts */
- if (phy_interrupt_is_valid(phydev)) {
- phydev->interrupts = PHY_INTERRUPT_ENABLED;
- if (phydev->drv->config_intr)
- phydev->drv->config_intr(phydev);
- }
-
- return 0;
+ return kszphy_config_reset(phydev);
}
static int kszphy_probe(struct phy_device *phydev)
--
2.7.4
next reply other threads:[~2017-12-12 11:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 11:02 Russell King [this message]
2017-12-14 18:21 ` [PATCH CFT] net: phy: micrel: remove unnecessary duplicate interrupt enable David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1eOiKC-0002ne-Mh@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox