netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King <rmk+kernel@armlinux.org.uk>
To: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Daniel Borkmann <daniel@iogearbox.net>
Subject: [PATCH net-next 10/13] ARM: net: bpf: avoid reloading 'index'
Date: Tue, 10 Jul 2018 13:36:55 +0100	[thread overview]
Message-ID: <E1fcrt1-0005VM-1a@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <20180710123340.GK17271@n2100.armlinux.org.uk>

Avoid reloading 'index' after we have validated it - it remains in
tmp2[1] up to the point that we begin the code to index the pointer
array, so with a little rearrangement of the registers, we can use
the already loaded value.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 arch/arm/net/bpf_jit_32.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c
index a375eb33ac69..8264cac1322c 100644
--- a/arch/arm/net/bpf_jit_32.c
+++ b/arch/arm/net/bpf_jit_32.c
@@ -1024,6 +1024,8 @@ static int emit_bpf_tail_call(struct jit_ctx *ctx)
 	emit(ARM_CMP_R(r_index, tmp[1]), ctx);
 	_emit(ARM_COND_CS, ARM_B(jmp_offset), ctx);
 
+	/* tmp2[1] = index */
+
 	/* if (tail_call_cnt > MAX_TAIL_CALL_CNT)
 	 *	goto out;
 	 * tail_call_cnt++;
@@ -1044,9 +1046,8 @@ static int emit_bpf_tail_call(struct jit_ctx *ctx)
 	 */
 	BUILD_BUG_ON(offsetof(struct bpf_array, ptrs) > ARM_ALU_IMM);
 	off = offsetof(struct bpf_array, ptrs);
-	r_array = arm_bpf_get_reg32(r2[1], tmp2[1], ctx);
+	r_array = arm_bpf_get_reg32(r2[1], tmp2[0], ctx);
 	emit(ARM_ADD_I(tmp[1], r_array, off), ctx);
-	r_index = arm_bpf_get_reg32(r3[1], tmp2[1], ctx);
 	emit(ARM_LDR_R_SI(tmp[1], tmp[1], r_index, SRTYPE_ASL, 2), ctx);
 	emit(ARM_CMP_I(tmp[1], 0), ctx);
 	_emit(ARM_COND_EQ, ARM_B(jmp_offset), ctx);
-- 
2.7.4

  parent reply	other threads:[~2018-07-10 12:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-10 12:33 [PATCH 00/13] ARM BPF jit compiler improvements Russell King - ARM Linux
2018-07-10 12:36 ` [PATCH net-next 01/13] ARM: net: bpf: enumerate the JIT scratch stack layout Russell King
2018-07-10 18:30   ` Daniel Borkmann
2018-07-10 21:57     ` Russell King - ARM Linux
2018-07-10 12:36 ` [PATCH net-next 02/13] ARM: net: bpf: provide load/store ops with negative immediates Russell King
2018-07-10 12:36 ` [PATCH net-next 03/13] ARM: net: bpf: use negative numbers for stacked registers Russell King
2018-07-10 12:36 ` [PATCH net-next 04/13] ARM: net: bpf: remove is_on_stack() and sstk/dstk Russell King
2018-07-10 12:36 ` [PATCH net-next 05/13] ARM: net: bpf: provide accessor functions for BPF registers Russell King
2018-07-10 12:36 ` [PATCH net-next 06/13] ARM: net: bpf: 64-bit " Russell King
2018-07-10 12:36 ` [PATCH net-next 07/13] ARM: net: bpf: access eBPF scratch space using ARM FP register Russell King
2018-07-10 12:36 ` [PATCH net-next 08/13] ARM: net: bpf: use immediate forms of instructions where possible Russell King
2018-07-10 19:12   ` kbuild test robot
2018-07-10 12:36 ` [PATCH net-next 09/13] ARM: net: bpf: use ldr instructions with shifted rm register Russell King
2018-07-10 12:36 ` Russell King [this message]
2018-07-10 12:37 ` [PATCH net-next 11/13] ARM: net: bpf: avoid reloading 'array' Russell King
2018-07-10 12:37 ` [PATCH net-next 12/13] ARM: net: bpf: always use odd/even register pair Russell King
2018-07-10 12:37 ` [PATCH net-next 13/13] ARM: net: bpf: use double-word load/stores where available Russell King
2018-07-10 17:03   ` Olof Johansson
2018-07-10 17:14     ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1fcrt1-0005VM-1a@rmk-PC.armlinux.org.uk \
    --to=rmk+kernel@armlinux.org.uk \
    --cc=daniel@iogearbox.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).