From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Michal Simek <michal.simek@xilinx.com>,
Harini Katakam <harinik@xilinx.com>,
Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Cc: Sean Anderson <sean.anderson@seco.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next 2/2] net: axienet: replace mdiobus_write() with mdiodev_write()
Date: Tue, 25 Jan 2022 16:10:16 +0000 [thread overview]
Message-ID: <E1nCOOe-005L92-JE@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <YfAgeKiKvxcQ0w57@shell.armlinux.org.uk>
Commit 0ebecb2644c8 ("net: mdio: Add helper functions for accessing
MDIO devices") added support for mdiodev accessor operations that
neatly wrap the mdiobus accessor operations. Since we are dealing with
a mdio device here, update the driver to use mdiodev_write().
Tested-by: Harini Katakam <harini.katakam@xilinx.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index 1ebdf1c62db8..de0a6372ae0e 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -1568,8 +1568,7 @@ static int axienet_pcs_config(struct phylink_pcs *pcs, unsigned int mode,
int ret;
if (lp->switch_x_sgmii) {
- ret = mdiobus_write(pcs_phy->bus, pcs_phy->addr,
- XLNX_MII_STD_SELECT_REG,
+ ret = mdiodev_write(pcs_phy, XLNX_MII_STD_SELECT_REG,
interface == PHY_INTERFACE_MODE_SGMII ?
XLNX_MII_STD_SELECT_SGMII : 0);
if (ret < 0) {
--
2.30.2
next prev parent reply other threads:[~2022-01-25 16:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 16:08 [PATCH net-next 0/2] net: axienet: modernise pcs implementation Russell King (Oracle)
2022-01-25 16:10 ` [PATCH net-next 1/2] net: axienet: convert to phylink_pcs Russell King (Oracle)
2022-01-25 16:10 ` Russell King (Oracle) [this message]
2022-01-26 15:50 ` [PATCH net-next 0/2] net: axienet: modernise pcs implementation patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1nCOOe-005L92-JE@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=davem@davemloft.net \
--cc=harinik@xilinx.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=radhey.shyam.pandey@xilinx.com \
--cc=sean.anderson@seco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).